Closed
Bug 1229472
Opened 10 years ago
Closed 10 years ago
Fix marionette-client dependencies so it could be installed via npm
Categories
(Testing Graveyard :: JSMarionette, defect)
Testing Graveyard
JSMarionette
Tracking
(firefox45 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | affected |
People
(Reporter: yzen, Assigned: yzen)
Details
Attachments
(1 file)
ATM npm i marionette-client will fail for the latest version because its package lists local file:.. dependencies. We should try using npm shrinkwrap to work around this issue.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8694352 [details] [review]
[gaia] yzen:bug-1229472 > mozilla-b2g:master
If I understand the docs (https://docs.npmjs.com/cli/shrinkwrap) correctly:
npm install will use the specific files referenced in "resolved" if available, falling back to normal package resolution using "version" if one isn't. So resolved is now pointing to local (in gaia) packages where package.json is pointing to versioned ones (corresponding to npm).
Note sockit-to-me is out of date on npm and need to be bumped 1.0.1->1.0.2
Attachment #8694352 -
Flags: review?(aus)
|
||
Updated•10 years ago
|
Attachment #8694352 -
Flags: review?(aus) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
Hi Aus, would you be able to publish the new version of marionette-client to npm as well? Thanks!
|
|
||
Comment 6•10 years ago
|
||
marionette-client@1.9.3 published. :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(aus)
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•10 years ago
|
||
thanks
|
|
Assignee | |
Comment 8•10 years ago
|
||
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•