Closed
Bug 1229482
Opened 9 years ago
Closed 9 years ago
Assets are ignored in Git
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
.gitignore was updated with the following entries: builds provisioning-profiles assets scripts That means any files with these names anywhere in the tree will be ignored, including Client/Assets/.
|
Assignee | |
Comment 1•9 years ago
|
||
Not sure what the intended behavior of the .gitignore changes were, so just taking a shot in the dark here. This assumes the ignored directories are all going to be top-level directories in the project.
Attachment #8694359 -
Flags: review?(etoop)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8694359 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1328 Yeah, the aim was ignore top level directory's with those names. My bad. Thanks for picking it up.
Attachment #8694359 -
Flags: review?(etoop) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
No problem, easy fix. Thanks for the quick review! https://github.com/mozilla/firefox-ios/commit/b17bc5de6441f0acb0bd9b23d856d846c3b7a3b3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•