Closed
Bug 1229486
Opened 9 years ago
Closed 9 years ago
FX_TABLETMODE_PAGE_LOAD reports the same counts for "desktop" and "tablet" mode
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 46
People
(Reporter: vladan, Assigned: Gijs)
References
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
jaws
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details |
On my Win7 Lenovo W520 laptop, I see the same counts for the "desktop" and "tablet" keys of the FX_TABLETMODE_PAGE_LOAD histogram. I never unplug this laptop from its 2 external monitors, and it does not have a touch screen, so it should never be in "tablet mode". Reproduces on Nightly 45 and Aurora 44.
Assignee | ||
Comment 1•9 years ago
|
||
Vladan and I debugged this over IRC - the TL;DR is that add(0) on a histogram does increment that histogram's "0" bucket, so it's not the same as just not calling it. To ensure we don't submit data for this histogram on non-win10, we should avoid finish() actually calling add() for the histogram.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1229486 - fix submission of tablet mode histogram on non-win10, r?jaws
Attachment #8694660 -
Flags: review?(jaws)
Assignee | ||
Comment 3•9 years ago
|
||
Jared: Tested on OSX, would be good if you can verify this does still submit stuff on win10 (it should, but there we go).
status-firefox44:
--- → affected
status-firefox45:
--- → affected
Assignee | ||
Comment 4•9 years ago
|
||
I verified that this is still working on Win10.
Comment 5•9 years ago
|
||
Comment on attachment 8694660 [details] MozReview Request: Bug 1229486 - fix submission of tablet mode histogram on non-win10, r?jaws https://reviewboard.mozilla.org/r/26825/#review25243 I didn't get a chance to test this locally but the patch looks good to me.
Attachment #8694660 -
Flags: review?(jaws) → review+
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb53c7d6b494
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8694660 [details] MozReview Request: Bug 1229486 - fix submission of tablet mode histogram on non-win10, r?jaws Approval Request Comment [Feature/regressing bug #]: telemetry for tablet mode on win10 [User impact if declined]: nonsensical telemetry submitted for other versions of Windows and other OSes [Describe test coverage new/current, TreeHerder]: no [Risks and why]: very low, correctness fix so we don't touch the relevant histogram except on win10+ [String/UUID change made/needed]: no
Attachment #8694660 -
Flags: approval-mozilla-beta?
Attachment #8694660 -
Flags: approval-mozilla-aurora?
Comment 9•8 years ago
|
||
Comment on attachment 8694660 [details] MozReview Request: Bug 1229486 - fix submission of tablet mode histogram on non-win10, r?jaws Improve our data, taking it.
Attachment #8694660 -
Flags: approval-mozilla-beta?
Attachment #8694660 -
Flags: approval-mozilla-beta+
Attachment #8694660 -
Flags: approval-mozilla-aurora?
Attachment #8694660 -
Flags: approval-mozilla-aurora+
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1ce9e7a3091a
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/d90ed2651b3d
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d90ed2651b3d
status-b2g-v2.5:
--- → fixed
Comment 13•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
status-b2g-v2.5:
fixed → ---
Comment 14•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in
before you can comment on or make changes to this bug.
Description
•