1229552 - SingletonEventManager unregister is broken

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1228044#c2

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

I checked that the test fails without the fix and also if we don't unregister at all.

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8694429 [details] [diff] [review]
patch

Review of attachment 8694429 [details] [diff] [review]:
-----------------------------------------------------------------

Heh. I was just about to fix this because eslint picked up the unused variable.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c6ec0bfaef5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7c6ec0bfaef5