SingletonEventManager unregister is broken

RESOLVED FIXED in Firefox 46

Status

RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla46

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

Created attachment 8694429 [details] [diff] [review]
patch

I checked that the test fails without the fix and also if we don't unregister at all.
Attachment #8694429 - Flags: review?(kmaglione+bmo)
Comment on attachment 8694429 [details] [diff] [review]
patch

Review of attachment 8694429 [details] [diff] [review]:
-----------------------------------------------------------------

Heh. I was just about to fix this because eslint picked up the unused variable.
Attachment #8694429 - Flags: review?(kmaglione+bmo) → review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7c6ec0bfaef5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46

Updated

2 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.