Closed Bug 1229552 Opened 4 years ago Closed 4 years ago

SingletonEventManager unregister is broken

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I checked that the test fails without the fix and also if we don't unregister at all.
Attachment #8694429 - Flags: review?(kmaglione+bmo)
Comment on attachment 8694429 [details] [diff] [review]
patch

Review of attachment 8694429 [details] [diff] [review]:
-----------------------------------------------------------------

Heh. I was just about to fix this because eslint picked up the unused variable.
Attachment #8694429 - Flags: review?(kmaglione+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/7c6ec0bfaef5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.