Closed
Bug 1229595
Opened 9 years ago
Closed 9 years ago
Find in Page: Animate between results
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bmunar, Mentored)
References
Details
(Whiteboard: [parity=safari][parity=chrome][lang=js][good first bug])
Attachments
(1 file)
|
48 bytes,
text/x-github-pull-request
|
bnicholson
:
review+
tecgirl
:
ui-review+
|
Details | Review |
Chrome and Safari both animate to Previous/Next results; the current implementation just jumps between them. We can add this polish with some JS interval animation.
|
Reporter | |
Comment 1•9 years ago
|
||
Would be a good first bug for anyone familiar with JS. Currently, we scroll to the result here: https://github.com/mozilla/firefox-ios/blob/47d2a6432ba96df91a736811a76c6e76b06f93d7/Client/Assets/FindInPage.js#L165. We can add a scroll animation by finding the difference between the current scroll position and that position, interpolating positions between them, and using an interval to scroll to each.
As a bonus, we could use an ease out curve to make the animation smoother.
Mentor: bnicholson
Whiteboard: [parity=safari][parity=chrome][lang=js][good first bug]
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bmunar
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8707183 -
Flags: ui-review?(randersen)
Attachment #8707183 -
Flags: review?(bnicholson)
|
||
Updated•9 years ago
|
Attachment #8707183 -
Flags: ui-review?(randersen) → ui-review+
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8707183 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1453
Left a few more comments in the PR; looks good with those changes.
Attachment #8707183 -
Attachment description: PR - i autoformatted it on Sublime, not sure how you want it to be formatted → Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1453
Attachment #8707183 -
Flags: review?(bnicholson) → review+
|
|
Reporter | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•