Closed Bug 1229613 Opened 4 years ago Closed 4 years ago

sccache unwillingly enabled on EC2 Windows PGO builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

The fix for bug 1181040 changed things such that automation builds end up using sccache because they set MOZ_PGO in the environment instead of through mozconfig.
Sccache was enabled mechanically by the switch to EC2 Windows instances, while
it is not intended to be used on PGO builds.

This happened because the fix for bug 1181040 disabled sccache for PGO builds
where MOZ_PGO is set through mozconfig (in which case MOZ_PGO_IS_SET is set)
*while* ignoring the case where MOZ_PGO is set through the environment (in
which case MOZ_PGO_IS_SET is, unconveniently, *not* set). The latter is what
Windows PGO builds do.
Attachment #8694525 - Flags: review?(mshal)
Attachment #8694525 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/93f0e6c2b2fd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.