Closed Bug 1229620 Opened 7 years ago Closed 7 years ago

Replace #ifdefs in b2g/ code by AppConstants

Categories

(Firefox OS Graveyard :: Runtime, defect)

Product:
Firefox OS Graveyard
Component:
Runtime
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
2.6 S2 - 12/4
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

(Whiteboard: [backout-asap])

Attachments

(1 file, 1 obsolete file)

eslint-b2g.patch
61.67 KB, patch
timdream
: review+
Details | Diff | Splinter Review 
That will let us run eslint on Js code in b2g/
Attached patch eslint-b2g.patch (obsolete) — — Splinter Review 
Blocks: eslint

    
    

    
  

      
      
      
      

        Attached patch
          
          
        eslint-b2g.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8694531 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8694934 [details] [diff] [review]
eslint-b2g.patch

Review of attachment 8694934 [details] [diff] [review]:
-----------------------------------------------------------------

Tim, do you want to take a look?

        Attachment #8694934 -
        Flags: review?(timdream)

    
    

    
  
Comment on attachment 8694934 [details] [diff] [review]
eslint-b2g.patch

Review of attachment 8694934 [details] [diff] [review]:
-----------------------------------------------------------------

\O/

::: b2g/chrome/content/settings.js
@@ +570,2 @@
>  
>  // ======================= Dogfooders FOTA ==========================

Move this comment above line 574?

        Attachment #8694934 -
        Flags: review?(timdream) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/92aebcffdfa9
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
Depends on: 1230633
Whiteboard: [backout-asap]

          You need to log in
          before you can comment on or make changes to this bug.