Closed
Bug 1229620
Opened 10 years ago
Closed 10 years ago
Replace #ifdefs in b2g/ code by AppConstants
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox45 fixed)
RESOLVED
FIXED
2.6 S2 - 12/4
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
(Whiteboard: [backout-asap])
Attachments
(1 file, 1 obsolete file)
|
61.67 KB,
patch
|
timdream
:
review+
|
Details | Diff | Splinter Review |
That will let us run eslint on Js code in b2g/
| Assignee | ||
Comment 1•10 years ago
|
||
| Assignee | ||
Comment 2•10 years ago
|
||
| Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8694531 -
Attachment is obsolete: true
| Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8694934 [details] [diff] [review]
eslint-b2g.patch
Review of attachment 8694934 [details] [diff] [review]:
-----------------------------------------------------------------
Tim, do you want to take a look?
Attachment #8694934 -
Flags: review?(timdream)
Comment 5•10 years ago
|
||
Comment on attachment 8694934 [details] [diff] [review]
eslint-b2g.patch
Review of attachment 8694934 [details] [diff] [review]:
-----------------------------------------------------------------
\O/
::: b2g/chrome/content/settings.js
@@ +570,2 @@
>
> // ======================= Dogfooders FOTA ==========================
Move this comment above line 574?
Attachment #8694934 -
Flags: review?(timdream) → review+
Comment 7•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
Updated•10 years ago
|
Whiteboard: [backout-asap]
You need to log in
before you can comment on or make changes to this bug.
Description
•