Closed
Bug 1229736
Opened 8 years ago
Closed 8 years ago
[Coverity 1202779] Avoid division by zero
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.22
People
(Reporter: paul.bignier, Assigned: paul.bignier)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1202779)
Attachments
(1 file)
687 bytes,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Build ID: 20151104125556 Steps to reproduce: Coverity's CID: 1202779
Assignee | ||
Updated•8 years ago
|
Component: Untriaged → Libraries
Product: Firefox → NSS
Version: 38 Branch → trunk
Updated•8 years ago
|
Assignee: nobody → paul.bignier
Blocks: nss-coverity
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Summary: Avoid division by zero → [Coverity 1202779] Avoid division by zero
Assignee | ||
Updated•8 years ago
|
Attachment #8694680 -
Flags: review?(brian)
Updated•8 years ago
|
Attachment #8694680 -
Flags: review?(brian) → review?(kaie)
Comment 1•8 years ago
|
||
Can a signed<->unsigned conversion ever turn a non-zero value into zero?
Comment 2•8 years ago
|
||
Comment on attachment 8694680 [details] [diff] [review] 0001-Avoid-division-by-zero.patch r=kaie Given that other error paths in this function don't bother to call PORT_SetError, it shouldn't be necessary to call PORT_SetError(SEC_ERROR_INVALID_ARGS);
Attachment #8694680 -
Flags: review?(kaie) → review+
Comment 3•8 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/3fc655349061
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.22
You need to log in
before you can comment on or make changes to this bug.
Description
•