Closed Bug 1229742 Opened 4 years ago Closed 4 years ago

MSE with trick mode DASH adaptation freezes playback on Firefox

Categories

(Core :: Audio/Video: Playback, defect, P2)

42 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox44 --- wontfix
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: rmittal, Assigned: jya)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

Steps to reproduce:

1. Use an MSE-based player that supports using TrickMode adaptations for video (see Trick Mode Support in http://dashif.org/w/2015/04/DASH-IF-IOP-v3.0.pdf ) for fast forward playback to play this stream  - http://de9b7h88wgj5l.cloudfront.net/stage/set5/dash_mbr/set5_dash_mbr_tp.mpd.

Or

1.Use an MSE-based player to play this stream  - http://de9b7h88wgj5l.cloudfront.net/stage/set5/dash_mbr/set5_dash_mbr_tp.mpd.
2. Change the player to use the video adaptation with id ="3" - this is the trick mode adaptation with frameRate=1/4.
3. Set playbackRate on the video tag to 2.



Actual results:

Playback freezes. The buffer seems to have enough segments to proceed but the video does not playback.


Expected results:

Video should playback at a rate of 2. This used to work in Firefox 41.
Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Do you have a link to a MSE-based player to test that?
Flags: needinfo?(rmittal)
I can provide a link to the player out of band in an email, please share an email id to provide the URL. Thanks!
Flags: needinfo?(rmittal)
Private email sent.
Priority: -- → P2
Assignee: nobody → jyavenard
Comment on attachment 8716917 [details]
MozReview Request: Bug 1229742: P2. Don't reject data promise if new data is pending. r?gerald

https://reviewboard.mozilla.org/r/33989/#review30723
Attachment #8716917 - Flags: review?(gsquelart) → review+
Comment on attachment 8716916 [details]
MozReview Request: Bug 1229742: P1. Only clear EOS flag if we have new data. r?gerald

https://reviewboard.mozilla.org/r/33987/#review30779
Attachment #8716916 - Flags: review?(gsquelart) → review+
https://hg.mozilla.org/mozilla-central/rev/386402ce5b3c
https://hg.mozilla.org/mozilla-central/rev/c4b606d703ce
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8716916 [details]
MozReview Request: Bug 1229742: P1. Only clear EOS flag if we have new data. r?gerald

Approval Request Comment
[Feature/regressing bug #]: 1229742
[User impact if declined]: playback stall 
[Describe test coverage new/current, TreeHerder]: In central for a few days, lots of MSE mochitest, manual testing
[Risks and why]: Low. We should have always done it this way, a condition that was overlooked. While the risk is low, being a racy situation it could happen with YouTube.
[String/UUID change made/needed]: None
Attachment #8716916 - Flags: approval-mozilla-beta?
Attachment #8716916 - Flags: approval-mozilla-aurora?
Comment on attachment 8716916 [details]
MozReview Request: Bug 1229742: P1. Only clear EOS flag if we have new data. r?gerald

Improve the video situation, taking it.
Should be in 45 beta 6.
Attachment #8716916 - Flags: approval-mozilla-beta?
Attachment #8716916 - Flags: approval-mozilla-beta+
Attachment #8716916 - Flags: approval-mozilla-aurora?
Attachment #8716916 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.