Closed
Bug 1229756
Opened 10 years ago
Closed 10 years ago
Send rewritten commit descriptions to Autoland
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dminor, Assigned: glob)
References
Details
Attachments
(1 file)
Now that bug 1220232 is fixed we should send the new commit descriptions to autoland so that they can be rewritten.
i've done most of the work here, but i've hit autoland issues at the final leg. dminor said he's happy to complete my patch.
Assignee: glob → dminor
dminor tells me the patch didn't require any additional changes, taking back to put up for review.
Assignee: dminor → glob
mozreview: actually send rewritten commit descriptions to autoland (bug 1229756) r?dminor
While commit descriptions were being rewritten and displayed to the user for
confirmation, the step of actually sending them to autoland was somehow missed.
This extends mozreview's autoland api call to accept a commit_descriptions
*json encoded string*, and passes it unmodified to autoland.
Attachment #8694823 -
Flags: review?(dminor)
| Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8694823 [details]
MozReview Request: mozreview: actually send rewritten commit descriptions to autoland (bug 1229756) r?dminor
https://reviewboard.mozilla.org/r/26893/#review24301
lgtm
Attachment #8694823 -
Flags: review?(dminor) → review+
| Reporter | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a2d805bdf9a5d20cfa7e34baac9fee53f43f1bce
mozreview: actually send rewritten commit descriptions to autoland (bug 1229756) r=dminor
| Reporter | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•