Build messages via Mozilla Pulse contain non-quoted URLs

RESOLVED INCOMPLETE

Status

Release Engineering
Release Automation
RESOLVED INCOMPLETE
2 years ago
8 months ago

People

(Reporter: whimboo, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Now that we switched our custom test runner to mozharness in mozmill-ci we see issues with downloading various files from archive.mozilla.org. That all happens because buildbot does not quote the URLs in the message. Attached you can find an example of a shorter normalized build message via pulsetranslator which maps those URLs 1:1.

mozharness failure:

> 14:24:53     INFO - Downloading http://archive.mozilla.org/pub/firefox/candidates/43.0b8-candidates/build1/mac/en-US/Firefox 43.0b8.dmg to /mozilla/code/gecko/testing/mozharness/build/Firefox 43.0b8.dmg
> 14:24:53     INFO - retry: Calling _download_file with args: (), kwargs: {'url': 'http://archive.mozilla.org/pub/firefox/candidates/43.0b8-candidates/build1/mac/en-US/Firefox 43.0b8.dmg', 'file_name': '/mozilla/code/gecko/testing/mozharness/build/Firefox 43.0b8.dmg'}, attempt #1
> 14:24:54  WARNING - Server returned status 404 HTTP Error 404: Not Found for http://archive.mozilla.org/pub/firefox/candidates/43.0b8-candidates/build1/mac/en-US/Firefox 43.0b8.dmg
Blocks: 1229762
I don't think the issue is that the URL isn't quoted so much as urllib2.urlopen() doesn't quote this properly.

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/script.py#303

Interestingly, urllib.urlopen() works, but urllib2.urlopen() doesn't.
As best it would need a fix on both places. Not all clients of Mozilla Pulse use mozharness and would also have to make sure to quote the url in case urllib2 is used. It would simply be nice to send out properly quoted urls.
I don't think we are going to touch buildbot a lot.
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.