1229762 - [pulsetranslator] Ensure to quote URL properties to reduce bustage for consumers

Status: RESOLVED FIXED

(Webtools :: Pulse, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As filed as bug 1229761 all URLs are not quoted and can cause bustage for consumers i.e. when mozharness is used. Best would be to ensure that urls are correctly quoted. So having a workaround until bug 1229761 got fixed would be nice.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Github PR

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We are currently blocked on this bug to run our tests for Firefox 43.0b8 candidate builds.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is not blocking us anymore given that I implemented a fix for mozharness. A buildbot fix is outstanding. So if you think its not worth fixing please close as wontfix.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8694714 [details] [review]
Github PR

Seems like it still makes sense to land; I'll merge and deploy.

Comment 5

[Jonathan Griffin (:jgriffin)]

remote: -----> Compressing... done, 47.9MB
remote: -----> Launching... done, v28
remote:        https://pulsetranslator.herokuapp.com/ deployed to Heroku
remote: 
remote: Verifying deploy.... done.
To https://git.heroku.com/pulsetranslator.git
   deff86e..1e54ac2  master -> master

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Something I missed to mention here is that for mozharness I pushed a slightly different change:
https://hg.mozilla.org/mozilla-central/rev/f3741d47fb6b

Jonathan, it might be better to also extend the safe characters for pulsetranslator.

Comment 7

[Jonathan Griffin (:jgriffin)]

Landed a corresponding change here:

https://github.com/mozilla/pulsetranslator/commit/1968d26c72e5eecd5f4703609131a655ee5c90f0

remote: -----> Compressing... done, 47.9MB
remote: -----> Launching... done, v29
remote:        https://pulsetranslator.herokuapp.com/ deployed to Heroku
remote: 
remote: Verifying deploy.... done.
To https://git.heroku.com/pulsetranslator.git
   1e54ac2..1968d26  master -> master