Closed Bug 1229780 Opened 4 years ago Closed 4 years ago

ClientLayerManager's texture pool helpers might use wrong texture pools

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: jnicol, Assigned: jnicol)

Details

Attachments

(1 file)

To fix bug 1209801 I made it so that TextureClientPools are distinguished by a TextureFlags parameter as well as a SurfaceFormat. The pool will then create TextureClients satisfying both the requested flags and format.

The helper functions ReturnTextureClientDeferred, ReturnTextureClient, and ReportClientLost were updated to use the TextureFlags of the client to guess which pool the client came from. It is possible, however, for a TextureClient to have additional flags to those that the pool requests. This could then cause the clients to be returned to incorrect pools.

The good news is that nobody is using these functions. The alternative of keeping a reference to the pool and returning the client directly to it is easy. I therefore propose that we remove these functions before my mistake causes an actual bug.
Attached patch Patch v1Splinter Review
Remove the functions
Attachment #8694734 - Flags: review?(matt.woodrow)
Attachment #8694734 - Flags: review?(matt.woodrow) → review+
Requesting checkin please.

Try run showing successful builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f088d9fd871
(No need for tests since we're just removing dead code.)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3e4476c099f9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.