If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enable popular domain suggestions for inline autocomplete

RESOLVED FIXED in Firefox 46

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Margaret, Assigned: mfinkle)

Tracking

35 Branch
Firefox 46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed, relnote-firefox 46+, fennec46+)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Filing this bug to track what's needed to ship this feature.
(Reporter)

Updated

2 years ago
tracking-fennec: --- → Nightly+
(Reporter)

Updated

2 years ago
Depends on: 1232433
(Reporter)

Updated

2 years ago
Depends on: 1232746
(Reporter)

Updated

2 years ago
Depends on: 1238109
Created attachment 8709099 [details] [diff] [review]
enable-defaultdomains v0.1

Enables using default domains. Also uses an initial capacity in the hashset since we know we'll have ~500 domains.
Assignee: nobody → mark.finkle
Attachment #8709099 - Flags: review?(margaret.leibovic)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8709099 [details] [diff] [review]
enable-defaultdomains v0.1

Review of attachment 8709099 [details] [diff] [review]:
-----------------------------------------------------------------

I'll let you take responsibility for making sure the documentation gets updated according to whatever legal wants.
Attachment #8709099 - Flags: review?(margaret.leibovic) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/5d3b491867b1

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5d3b491867b1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
(Assignee)

Updated

2 years ago
Depends on: 1240599
(Assignee)

Updated

2 years ago
tracking-fennec: Nightly+ → 46+
Noted  for beta 46 as "Include a list of popular domains for inline autocompletion when typing in the URL bar"
Margaret or Barbara, I think this would be good to explain in a blog post (to get across more clearly that the default domains would be replaced by often visited domains from user history ) If you do write something we can link to it from the notes when 46 goes to the release channel.
Flags: needinfo?(bbermes)
relnote-firefox: --- → 46+
(Reporter)

Comment 6

2 years ago
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5)
> Noted  for beta 46 as "Include a list of popular domains for inline
> autocompletion when typing in the URL bar"
> Margaret or Barbara, I think this would be good to explain in a blog post
> (to get across more clearly that the default domains would be replaced by
> often visited domains from user history ) If you do write something we can
> link to it from the notes when 46 goes to the release channel.

Mentioned this in another bug, but I'll repeat it here. We have technical documentation here:
https://gecko.readthedocs.org/en/latest/mobile/android/fennec/defaultdomains.html#domain-auto-completion

I'm not sure that this needs a blog post, since it's something that users shouldn't really notice (other than just seeing better suggestions when typing in the urlbar).
Agreed, with Maragret, link to docs seems fine
Flags: needinfo?(bbermes)
You need to log in before you can comment on or make changes to this bug.