Closed Bug 1229862 Opened 4 years ago Closed 4 years ago

Enable popular domain suggestions for inline autocomplete

Categories

(Firefox for Android :: General, defect)

35 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed
relnote-firefox --- 46+
fennec 46+ ---

People

(Reporter: Margaret, Assigned: mfinkle)

References

Details

Attachments

(1 file)

Filing this bug to track what's needed to ship this feature.
tracking-fennec: --- → Nightly+
Depends on: 1232433
Depends on: 1232746
Depends on: 1238109
Enables using default domains. Also uses an initial capacity in the hashset since we know we'll have ~500 domains.
Assignee: nobody → mark.finkle
Attachment #8709099 - Flags: review?(margaret.leibovic)
Comment on attachment 8709099 [details] [diff] [review]
enable-defaultdomains v0.1

Review of attachment 8709099 [details] [diff] [review]:
-----------------------------------------------------------------

I'll let you take responsibility for making sure the documentation gets updated according to whatever legal wants.
Attachment #8709099 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/5d3b491867b1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Depends on: 1240599
tracking-fennec: Nightly+ → 46+
Noted  for beta 46 as "Include a list of popular domains for inline autocompletion when typing in the URL bar"
Margaret or Barbara, I think this would be good to explain in a blog post (to get across more clearly that the default domains would be replaced by often visited domains from user history ) If you do write something we can link to it from the notes when 46 goes to the release channel.
Flags: needinfo?(bbermes)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5)
> Noted  for beta 46 as "Include a list of popular domains for inline
> autocompletion when typing in the URL bar"
> Margaret or Barbara, I think this would be good to explain in a blog post
> (to get across more clearly that the default domains would be replaced by
> often visited domains from user history ) If you do write something we can
> link to it from the notes when 46 goes to the release channel.

Mentioned this in another bug, but I'll repeat it here. We have technical documentation here:
https://gecko.readthedocs.org/en/latest/mobile/android/fennec/defaultdomains.html#domain-auto-completion

I'm not sure that this needs a blog post, since it's something that users shouldn't really notice (other than just seeing better suggestions when typing in the urlbar).
Agreed, with Maragret, link to docs seems fine
Flags: needinfo?(bbermes)
You need to log in before you can comment on or make changes to this bug.