Closed
Bug 1229911
Opened 9 years ago
Closed 9 years ago
eslint doesn't recognize DevToolsUtils.defineLazyGetter
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
Details
Attachments
(1 file, 1 obsolete file)
1.20 KB,
patch
|
tromey
:
review+
|
Details | Diff | Splinter Review |
Examine the eslint results for
devtools/shared/styleinspector/css-logic.js
For me it gives some errors because "domUtils" is not defined.
But domUtils is defined via:
DevToolsUtils.defineLazyGetter(this, "domUtils", function() {
return Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);
});
The problem is that helpers.js doesn't recognize DevToolsUtils.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8694916 [details] [diff] [review]
recognize DevToolsUtils.defineLazyGetter and defineLazyModuleGetter
I had this look at defineLazyModuleGetter and defineLazyGetter,
but not defineLazyPrototypeGetter, as that one didn't seem
necessary.
Attachment #8694916 -
Flags: review?(mratcliffe)
Attachment #8694916 -
Flags: review?(mratcliffe) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8699187 -
Flags: review+
Keywords: checkin-needed
Comment 6•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Summary: eslint doesn't recognize DevtoolsUtils.defineLazyGetter → eslint doesn't recognize DevToolsUtils.defineLazyGetter
Comment 7•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•