Closed Bug 1229911 Opened 4 years ago Closed 4 years ago

eslint doesn't recognize DevToolsUtils.defineLazyGetter

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: tromey, Assigned: tromey)

Details

Attachments

(1 file, 1 obsolete file)

Examine the eslint results for
devtools/shared/styleinspector/css-logic.js

For me it gives some errors because "domUtils" is not defined.
But domUtils is defined via:

DevToolsUtils.defineLazyGetter(this, "domUtils", function() {
  return Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);
});


The problem is that helpers.js doesn't recognize DevToolsUtils.
Comment on attachment 8694916 [details] [diff] [review]
recognize DevToolsUtils.defineLazyGetter and defineLazyModuleGetter

I had this look at defineLazyModuleGetter and defineLazyGetter,
but not defineLazyPrototypeGetter, as that one didn't seem
necessary.
Attachment #8694916 - Flags: review?(mratcliffe)
Attachment #8694916 - Flags: review?(mratcliffe) → review+
Rebased.
Attachment #8694916 - Attachment is obsolete: true
Attachment #8699187 - Flags: review+
No tests for this, so no try run.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3e3f7dd7190f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Summary: eslint doesn't recognize DevtoolsUtils.defineLazyGetter → eslint doesn't recognize DevToolsUtils.defineLazyGetter
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.