1229913 - Empty class and id displayed in animation inspector

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Tim Nguyen :ntim]

Attachment: empty-classid-animation.PNG

STR:
Go to https://twitter.com/cssanimation
Hover around the page (notably in the tweet section)

Comment 1

[Patrick Brosset <:pbro>]

Thanks for filing Tim. I've seen this in the past too. I think there's a race somewhere in the code that makes the UI refresh mechanism fail in all sorts of ways when you quickly trigger new animations on a page.
Another way to do this is:
- go to about:home
- quickly move your mouse over the launch icons at the bottom

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug_1229913_-_Prevent_race_conditions_when_there_a.diff

Comment 3

[Patrick Brosset <:pbro>]

We want to handle animation mutation events synchronously to avoid race conditions when there are many rapid mutations.
So when a mutation occurs and animations are removed, we don't release the corresponding actors in a blocking way, we just release asynchronously and don't wait for completion, but instead store the promise in an array.
The array is then passed to 'promise.all' in the panel's destroy method.

Comment 4

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1229913 - Prevent race conditions when there are many animation mutations; r=miker

Review commit: https://reviewboard.mozilla.org/r/33009/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33009/

Comment 5

[Patrick Brosset <:pbro>]

I've been investigating a seemingly unrelated test failure on try, and filed bug 1245420 as a result.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8714314 [details]
MozReview Request: Bug 1229913 - Prevent race conditions when there are many animation mutations; r=miker

https://reviewboard.mozilla.org/r/33009/#review30093

Comment 7

[Patrick Brosset <:pbro>]

With bug 1245420 fixed, try looks good now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=662864dd85c7&group_state=expanded

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f09ea2712445

Comment 9

[Carsten Book [:Tomcat]]

had to back this out in https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=073aa15f8ea4 - seems one of this 2 pushes caused test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7041768&repo=fx-team

Comment 10

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/217f088bd9ac

Comment 11

[Patrick Brosset <:pbro>]

This got backed out because pushed together with bug 1245420 as it depends on it.
I have pushed a new fix for bug 1245420 to fx-team. So I'll be able to push this patch again soon.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3c02ec7bd6b8

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3c02ec7bd6b8