1229920 - Sync stuck at signing in.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Sync, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2015-12-02-13-33-31.png

1. go to settings
2. go to Firefox Sync
3. tap sign in
4. sign in with Firefox account

Expected: signed in
Actual: not signed in with a light blued out "signing in..." button

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat.txt

Logcat of the event.  
Note: 
1. I have only sim data connection (not wifi) 
2. I messed up in logging in the first time.

Comment 2

[Marcia Knous [:marcia]]

Tested using the build on taskcluster with an existing Firefox account that I have been using:

Build ID               20151202152725
Gaia Revision          d379f6f96cd716467568a4d8ca2472fc5be5c577
Gaia Date              2015-12-02 13:22:56
Gecko Revision         https://hg.mozilla.org/releases/b2g-ota/rev/8e007a507475df919661a757b18f728ca130b87a
Gecko Version          45.0a1
Device Name            aries

I see the same behavior as Naoki in Comment 0 - I am stuck at the "Signing in" stage - the blue button is highlight but it never finishes the process of signing me in.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Requesting https://github.com/mozilla-b2g/gaia/commit/d60a533a33b45f33ce5486495190f11a304d1705 be backed out until this bug is fixed.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mahe, Michiel, comment 3 has the sync commit in question that needs to be backed out until this bug is resolved.  Michiel, would you mind taking care of this please?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I also found that I get stuck after adding some web pages, reflashing the phone and then trying to directly sign into sync again on a new account.

Comment 6

[Mahendra Potharaju [:mahe]]

Michiel, Can you please back this out today?  We are trying to provide an OTA update before Orlando and its better to not have users get this experience. 

Thanks

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

This looks like E/GeckoConsole(  320): [JavaScript Error: "uncaught exception: No connections registered"] which is probably caused by bug 1225450

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Actually, bug 1225450 works. The problem seems to be that the Sync app is missing from the taskcluster build.

Comment 9

[[:fabrice] Fabrice Desré]

I got the same issue with a local build, gaia pushed with |NOFTU=1 make production|

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

We are missing the sync app here https://mxr.mozilla.org/gaia/source/build/config/phone/apps-production.list

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1229920.sync.production > mozilla-b2g:master

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/c705ce00353ff8e529a27c31feac71759e009c6a

Comment 13

[Gabriela [:gaby2300]]

In my case I get: I get Ooops... Something went wrong

Comment 14

[Martin Shuman [:Marty]]

This issue is still occurring on the latest Flame 2.6 Nightly and Aries 2.6 Dogfood builds.
The user gets stuck signing into Sync if they are already logged into a FxA on the device before going to Sync and tapping 'Getting Started'.  The user can sign in only if they create a brand new FxA in Settings > Sync.  If they create a new account in Settings > Firefox Accounts, then navigate to Sync and tap 'Getting Started', they will not be able to progress.

Environmental Variables:
Device: Aries 2.6
BuildID: 20151204122048
Gaia: e9419046f360dd05b2717c4994990608519b93e4
Gecko: e02b17a2b5b8df7bb84f325fc08eedd2f3cab755
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Flame 2.6
BuildID: 20151204030224
Gaia: e9419046f360dd05b2717c4994990608519b93e4
Gecko: e02b17a2b5b8df7bb84f325fc08eedd2f3cab755
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Comment 15

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Fernando and Fabrice, This issue is still occurring in a build that does contain the patch.  Can you please look at this?

Comment 16

[Michiel de Jong [:michielbdejong]]

Could not reproduce with B2G-Desktop from master, will try with Flame from the '04-Dec-2015 13:34' build on https://ftp.mozilla.org/pub/b2g/nightly/latest-mozilla-central-flame-kk/.

Comment 17

[Michiel de Jong [:michielbdejong]]

Could not reproduce with Flame either (I logged in to FxA from FTU, then enabled Firefox Sync, and it's syncing now). Will try some more combinations of signing in/signing out, to see if I find any errors.

Marty, by 'get stuck signing into Sync', do you mean nothing happens when you click 'Get started'? Or does the view briefly disappear and come back again to the screen with the 'Get started' button?

Comment 18

[[:fabrice] Fabrice Desré]

I was able to go past this error with current master, but sync never finished. It errored out, and now I'm stuck at the "Get started" step, with the following:
E/GeckoConsole(19506): Content JS ERROR: Error: Transition enable invalid for the current state 
E/GeckoConsole(19506):     at ["_handle_iac-gaia-sync-management"] (app://system.gaiamobile.org/js/sync_manager.js:219:13)
E/GeckoConsole(19506):     at EventMixin.handleEvent (app://system.gaiamobile.org/js/base_module.js:344:9)
E/GeckoConsole(19506):     at onReceivedMessage (app://system.gaiamobile.org/shared/js/iac_handler.js:39:11)

Comment 19

[[:fabrice] Fabrice Desré]

and... things appeared to be magically fixed now. I see my history in the browser app.

Comment 20

[Michiel de Jong [:michielbdejong]]

Oh right, I reproduced it now, sorry I was using an existing account earlier, not creating a new one from the Firefox Accounts menu. Once the account is activated (email verified), if you go to the Firefox Sync menu and click 'Get started', it says 'Signing in...', then 'Oops... something went wrong', then when you click 'ok' it goes back to 'Get started'. The second time I clicked, it worked (and went to 'this account is empty').

I created bug 1230676 about this specific case, since it's different from the problem this bug was originally about.

Comment 21

[Michiel de Jong [:michielbdejong]]

Canceling needinfo's in favor of bug 1230676, see my previous comment.

Fabrice, the problem where sync never finished is fixed by bug 1230224 (already reviewed, just needs merging).

Comment 22

[Martin Shuman [:Marty]]

Michiel, I am still seeing the original behavior written for this bug. I am already signed into an FxA (New account, just activated.) and navigate to Settings > Sync and I tap 'Getting Started.'  The button changes to 'Signing in...' (viewable in attachment 8694935 [details]) and displays this indefinitely, without timing out or failing. Closing and reopening the app still displays the 'Signing in...' button. Rebooting the device will then cause it to display the original 'Getting Started' button.

Comment 23

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I am also seeing this reproduce as written in comment 0 when signing in from FTU or Settings.

Comment 24

[Michiel de Jong [:michielbdejong]]

Hi Marty and Jayme,

Thanks, I have been able to reproduce it once, and when it happens, it's quite annoying because you can only get past it with a reboot.

But I tried at least 40 or 50 times on Flame and B2G-Desktop to reproduce it again, and have been unsuccessful.

Can you reproduce this problem consistently? And can you also reproduce it in B2G-Desktop?

Comment 25

[Fernando Jiménez Moreno [:ferjm]]

(In reply to [:fabrice] Fabrice Desré from comment #18)
> I was able to go past this error with current master, but sync never
> finished. It errored out, and now I'm stuck at the "Get started" step, with
> the following:
> E/GeckoConsole(19506): Content JS ERROR: Error: Transition enable invalid
> for the current state 
> E/GeckoConsole(19506):     at ["_handle_iac-gaia-sync-management"]
> (app://system.gaiamobile.org/js/sync_manager.js:219:13)
> E/GeckoConsole(19506):     at EventMixin.handleEvent
> (app://system.gaiamobile.org/js/base_module.js:344:9)
> E/GeckoConsole(19506):     at onReceivedMessage
> (app://system.gaiamobile.org/shared/js/iac_handler.js:39:11)

This is probably bug 1230210 after the Sync app is killed because of OOM. Now that we have bug 915880 is way easier to detect this situation. I'll have a fix for this along the weekend.

In any case, the Sync app should never be killed because of OOM after bug 1230224.

(In reply to [:fabrice] Fabrice Desré from comment #19)
> and... things appeared to be magically fixed now. I see my history in the
> browser app.

And this is the sync manager fixing the mess on the next automatic sync request.

Thanks for all the reports :) Is good to have this being tested for real.

Comment 26

[Fernando Jiménez Moreno [:ferjm]]

Still needinfo me to check comment 14.

Comment 27

[Adam Alldredge [:AdamA][Inactive]]

We are not seeing this issue occurring on Flame 2.6, but we are still seeing it occur on Aries 2.6.
I have signed in using the same method and the same account on both devices and it will not progress past signing in on the Aries device, But on Flame it will progress past the signing in screen and show that I am signed into sync.

Environmental Variables:
Device: Aries 2.6 [Full Flash]
BuildID: 20151208121557
Gaia: 6b430ea7274af4c352de16b75e6bb85d7621ca83
Gecko: 2bdd9ec79799eff3ceec0a318f5a0632d918a527
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: FlameKK 2.6 [Full Flash][512mb]
BuildID: 20151208030225
|Gaia: 6b430ea7274af4c352de16b75e6bb85d7621ca83
Gecko: 2bdd9ec79799eff3ceec0a318f5a0632d918a527
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D v4

Comment 28

[Fernando Jiménez Moreno [:ferjm]]

Adam, could you provide a logcat, please?

Comment 29

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Setting qawanted to get the logcat for this issue.

Comment 30

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: Aries_sync_not_signing_in_logcat.txt

Fernando here is the logcat you requested.  The following bit seems to be the likely cause.  I was connected to wifi and also had data enabled.

12-09 10:11:49.907   320   320 E GeckoConsole: Content JS ERROR: No connections registered 
12-09 10:11:49.907   320   320 E GeckoConsole:     at <anonymous> (app://system.gaiamobile.org/js/sync_manager.js:632:13)
12-09 10:11:49.907   320   320 I GeckoDump: DeveloperHUD: [app://system.gaiamobile.org/manifest.webapp] Error (console)
12-09 10:11:49.907   320   320 I Gecko   : XXX FIXME : Dispatch a developer-hud-update: undefined
12-09 10:11:57.157   320   320 E GeckoConsole: [JavaScript Error: "uncaught exception: No connections registered"]
12-09 10:11:57.167   320   320 I GeckoDump: DeveloperHUD: [app://system.gaiamobile.org/manifest.webapp] Error (content javascript): "uncaught exception: No connections registered" in :0:0

Comment 31

[Fernando Jiménez Moreno [:ferjm]]

Thank you Jayme. That looks the same issue that the attached PR is supposed to fixed.

Fabrice, do you know which apps .list config file do we use to generate Aries builds?

Comment 32

[:gerard-majax]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #31)
> Thank you Jayme. That looks the same issue that the attached PR is supposed
> to fixed.
> 
> Fabrice, do you know which apps .list config file do we use to generate
> Aries builds?

There: https://github.com/mozilla-b2g/gaia/blob/dea66f0233e2558aec1ca37e925462aff580c98b/distros/spark/apps.list

Comment 33

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1229920.followup > mozilla-b2g:master

Comment 34

[Fernando Jiménez Moreno [:ferjm]]

Does it make sense to add sync to b2gdroid builds as well or should we disable Sync there?

Comment 35

[[:fabrice] Fabrice Desré]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #34)
> Does it make sense to add sync to b2gdroid builds as well or should we
> disable Sync there?

We need to do the same as for gonk based phones, so let's add it.

Comment 36

[[:fabrice] Fabrice Desré]

Comment on attachment 8697393 [details] [review]
[gaia] ferjm:bug1229920.followup > mozilla-b2g:master

can you add it to distros/b2gdroid too?

Comment 37

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/321984cce83cb3ad46d7d7129d6e0e3d324eb3df

Comment 38

[Adam Alldredge [:AdamA][Inactive]]

This issue is verified fixed on Aries 2.6 and Flame 2.6.

Environmental Variables:
Device: Aries 2.6 [Full Flash]
BuildID: 20151214121335
Gaia: ad15b4f1f50f4e28170a069f049e5bdeec8d15cc
Gecko: 99137d6d4061f408ae0869122649d8bdf489cc30
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: FlameKK 2.6 [Full Flash][512mb]
Build ID: 20151214030209
Gaia: ad15b4f1f50f4e28170a069f049e5bdeec8d15cc
Gecko: 99137d6d4061f408ae0869122649d8bdf489cc30
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6)
Firmware Version: v18D v4
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Result:
User is able to log into firefox sync using previously made accounts.