Consider switching to




Firefox for Android
2 years ago
2 years ago


(Reporter: mcomella, Unassigned)


Firefox Tracking Flags

(Not tracked)


SetHomepagePreference extends DialogFragment, but it should be the v7 DialogFragment, not the built in.

Investigate whether this is worthwhile and what the effects are. This may be necessary after bug 1205124 lands.

Note that preferences and AppCompat are apparently really funky business.
Andrzej, you have the context here – do we need to do anything with this?
Flags: needinfo?(ahunt)

Comment 3

2 years ago
(In reply to Michael Comella (:mcomella) from comment #2)
> Andrzej, you have the context here – do we need to do anything with this?

I don't think we need to do anything immediately, using AppCompatActivity around Preferences doesn't seem to result in any issues.

Switching to the v7 DialogFragment would probably result in us using the support library dialog as opposed to the native dialog when setting a custom homepage. Since we're producing native (non-support library dialogs) in the rest of preferences, we probably wouldn't want to do that, unless we can switch all of preferences to use support library dialogs. (IIRC the PreferenceFragment that we use elsewhere spawns native Android dialogs - it looks like we might be able to upgrade to PreferenceFragmentCompat instead?)
Flags: needinfo?(ahunt)
Okay, I'm going to close this and we can reopen or file a new bug if we decide to do any of the options in comment 3.
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.