Closed Bug 1229944 Opened 4 years ago Closed 4 years ago

ANGLE_depth_texture requires glClear to zero texImages (no uploads allowed)

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 + fixed
firefox46 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(3 files)

So we do need to support using glClear to zero things. The new code only does calloc uploads.
Attachment #8694972 - Flags: review?(dglastonbury)
Try is green, though this behavior is basically untested, so this isn't hugely surprising.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f685842426c9
Attachment #8694972 - Flags: review?(dglastonbury) → review+
Attachment #8694973 - Flags: review?(dglastonbury) → review+
Depends on: 1229585
https://hg.mozilla.org/mozilla-central/rev/4eb69feafc3d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Depends on: webgl-tex-refactor
[Tracking Requested - why for this release]: depth textures are somewhat broken without this, which will cause crashes.
See Also: → 1232346
Here's a test for this.
Attachment #8698639 - Flags: review?(dglastonbury)
Attachment #8698639 - Flags: review?(dglastonbury) → review+
Comment on attachment 8694972 [details] [diff] [review]
0001-Bail-earlier-if-resolve-fails.patch

Approval Request Comment
[Feature/regressing bug #]: bug webgl-tex-refactor
[User impact if declined]: WEBGL_depth_texture won't work.
[Describe test coverage new/current, TreeHerder]: Test included with csets.
[Risks and why]: Very low.
[String/UUID change made/needed]: None.
Attachment #8694972 - Flags: approval-mozilla-aurora?
Comment on attachment 8694972 [details] [diff] [review]
0001-Bail-earlier-if-resolve-fails.patch

Should be safe, taking it in aurora.
Attachment #8694972 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
There are several things that landed to inbound in here. What exactly needs uplifted to aurora?
Flags: needinfo?(jgilbert)
(In reply to Wes Kocher (:KWierso) (On vacation until Dec 28) from comment #17)
> There are several things that landed to inbound in here. What exactly needs
> uplifted to aurora?

I'll handle it.
Flags: needinfo?(jgilbert)
Flags: needinfo?(jgilbert)
Huh, I thought I did this.
Flags: needinfo?(jgilbert)
(In reply to Wes Kocher (:KWierso) from comment #20)
> Oh, looks like you did.
> 
> https://hg.mozilla.org/releases/mozilla-aurora/rev/ca3b15d9e483
> https://hg.mozilla.org/releases/mozilla-aurora/rev/f5b4bfb33ab4

You beat me to it. I expected pulsebot to pick up on it, but I guess that's inbound-only?
You need to log in before you can comment on or make changes to this bug.