1229974 - Failed to clean updated system add-ons directories.: Unix error 2 during operation DirectoryIterator.prototype.next

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[aleth [:aleth]]

Happens sometime after startup:

addons.update-checker	WARN	Update manifest for [e-mail] did not contain an updates property
addons.xpi   ERROR	Failed to clean updated system add-ons directories.: Unix error 2 during operation DirectoryIterator.prototype.next on file /Library/Thunderbird/Profiles/default/features (No such file or directory) ((unknown module)) No traceback available

Comment 1

[Wayne Mery (:wsmwk)]

regression?

Comment 2

[aleth [:aleth]]

(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #1)
> regression?

No, system addons are fairly new. Afaik shipping Calendar as a system addon is under consideration.

Comment 3

[ISHIKAWA, Chiaki]

(In reply to aleth [:aleth] from comment #0)
> Happens sometime after startup:
> 
> addons.update-checker	WARN	Update manifest for
> [e-mail] did not contain an updates property
> addons.xpi   ERROR	Failed to clean updated system add-ons directories.: Unix
> error 2 during operation DirectoryIterator.prototype.next on file
> /Library/Thunderbird/Profiles/default/features (No such file or directory)
> ((unknown module)) No traceback available

This error is actually a little irritating. It seems to happen randomly during |make mozmill| test (when I run it locally on my PC using full debug build) and when it happens, it seems to slowdown the test (or block the execution for several seconds).
Hmm...

Seeing "Iterator" in the identifier string reminds me of 
the changes to for-style iterators in JavaScript (due to ES specification changes), and this could be related to that (?)

Comment 4

[Frank-Rainer Grahl (:frg)]

Also happens in Seamonkey. Bug 1192921 added a system addons directory. If you just add an empty features directory in the profile it seems to go away without side effects. 

Error is generated here:

toolkit/mozapps/extensions/internal/XPIProvider.jsm

Comment 5

[duncanSF]

Also seen in Firefox 44.0.2 on OSX 10.6.8. FF went unresponsive and got killed.

FF was launched from Terminal so I have stdout and stderr messages:

1456656920567	addons.update-checker	WARN	Update manifest for {972ce4c6-7e08-4474-a285-3208198ce6fd} did not contain an updates property
1456656921368	addons.xpi	ERROR	Failed to clean updated system add-ons directories.: Unix error 2 during operation DirectoryIterator.prototype.next on file /Users/mylogin/Library/Application Support/Firefox/Profiles/ko597imn.default/features (No such file or directory) ((unknown module)) No traceback available

If I take out the word "features" ls shows the parent directory does exist.  Exactly as listed, it doesn't.

Comment 6

[Kent James (:rkent)]

Since Thunderbird is not using system add-on, does not make sense to block on this.

Comment 7

[ISHIKAWA, Chiaki]

Just FYI, this happens under Windows 10, too.

This is from a Japanese environment and thus the error messages are localized.

時刻: 2016/05/01 22:53:09
エラー: 1462110789613	addons.xpi	ERROR	Failed to clean updated system add-ons directories.: Win error 2 during operation DirectoryIterator.prototype.next on file C:\Users\ci\AppData\Roaming\Thunderbird\Profiles\xxyyz.default\features (指定されたファイルが見つかりません。
) ((unknown module)) No traceback available
ソースファイル: resource://gre/modules/Log.jsm
行: 751

It says that the specified file was not found.
I think there is an incorrect path specification somewhere, or that
the code that handles this does not pay attention to the possibility of the said file not being there.

Comment 8

[Frank-Rainer Grahl (:frg)]

Bug 1246614 took care of it and you should no longer see the errors in TB 47+ unless the directory exists and something goes really wrong. If the directory does not exist just ignore it.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Frank-Rainer Grahl from comment #8)
> Bug 1246614 took care of it and you should no longer see the errors in TB
> 47+ unless the directory exists and something goes really wrong. If the
> directory does not exist just ignore it.

still an issue?

Comment 10

[aleth [:aleth]]

I've not seen this for a while, and given comment 8 it should be fixed.