Closed
Bug 1230049
Opened 9 years ago
Closed 9 years ago
Remove switches.css dependency from mobile wallet dev app
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
Attachments
(1 file)
Let's replace all instances of switches.css with web components!
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8695125 [details] [review] [gaia] KevinGrandon:bug_1230049_mobile_wallet_update_switches > mozilla-b2g:master Krzysztof or Tim - would either of you mind giving this a review? Just trying to port building blocks over to web components. I wasn't able to verify this on a device (seems it doens't work on a flame), but I was able to verify that it renders properly in the mulet. There is one problem with the header, but it isn't caused by this patch. Thanks!
Attachment #8695125 -
Flags: review?(timdream)
Attachment #8695125 -
Flags: review?(kmioduszewski)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8695125 [details] [review] [gaia] KevinGrandon:bug_1230049_mobile_wallet_update_switches > mozilla-b2g:master LGTM assuming the layout did not change.
Attachment #8695125 -
Flags: review?(timdream)
Attachment #8695125 -
Flags: review?(kmioduszewski)
Attachment #8695125 -
Flags: review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Thanks for the review. In master: https://github.com/mozilla-b2g/gaia/commit/831b5706d836c14074c9eb8f9736fa50d3691a7e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•