123005 - [viewpoint ] mouse events don't pass correct wparam

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Ari Berger]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0)
BuildID:    0.9.4 branch

In mouse messages (eg mousemove), you set the following bits:
MK_SHIFT, MK_CONTROL
We also expect the following:
MK_LBUTTON, MK_RBUTTON, MK_MBUTTON
In short, you could probably just pass through the wparam from windows.



Reproducible: Always
Steps to Reproduce:
1.Unfortunately, this is tough to reproduce with our plugin.  You will need to 
install us AND adobe atmosphere.
2.I will try to put together an installer for you. Overall, it is probably 
easier if I test out the patch.
3.

Comment 1

[Peter Lubczynski]

arrrg...I had a patch for this, but the virus I caught this weekend ate it!
Let's try again....

Comment 2

[Michael Dunn]

Adding KW

Comment 3

[Peter Lubczynski]

Attachment: patch to propigate raw wParam to plugin for Windows

This patch takes the same approach as the keyboard one in bug 122501 by
propigating the raw wParam down to the plugin. 

Ari, since there's no testcase here, can you be sure you test this out well. 

Thanks!

Comment 4

[Kevin McCluskey (gone)]

Comment on attachment 67759 [details] [diff] [review]
patch to propigate raw wParam to plugin for Windows

r=[e-mail]

Comment 5

[Patrick C. Beard]

Comment on attachment 67759 [details] [diff] [review]
patch to propigate raw wParam to plugin for Windows

sr=beard
Let's get a LOT of regression testing on known interactive plugins, Quicktime,
etc.

Comment 6

[Peter Lubczynski]

Patch in trunk to bake.

Seeking approval for branch.

Comment 7

[Michael Dunn]

Plus'ing. 
Shrirang, Btrent heads up.
Question: will this be hittin the trunk? 

Comment 8

[Peter Lubczynski]

this fix should already be in today's trunk builds

Comment 9

[Marek Z. Jeziorek]

approved for branch

Comment 10

[Peter Lubczynski]

fixed0.9.4

Comment 11

[shrirang khanzode]

all important plugins have been tested on the trunk/branch(0206). I see no 
regressions... Ari, can you please verify the fix for this bug since there is no 
testcase here to check this one out. Thanks !!

Comment 12

[shrirang khanzode]

v(stamp)