1230053 - Duplicate case labels in setup.js:onWizardBack

Status: RESOLVED DUPLICATE of bug 1231728

(Firefox :: Sync, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

onWizardBack: function () {
    switch (this.wizard.pageIndex) {
      case NEW_ACCOUNT_START_PAGE:
      case EXISTING_ACCOUNT_LOGIN_PAGE:
        this.wizard.pageIndex = INTRO_PAGE;
        return false;
      case EXISTING_ACCOUNT_CONNECT_PAGE:
        this.abortEasySetup();
        this.wizard.pageIndex = INTRO_PAGE;
        return false;
      case EXISTING_ACCOUNT_LOGIN_PAGE:
        // If we were already pairing on entry, we went straight to the manual
        // login page. If subsequently we go back, return to the page that lets
        // us choose whether we already have an account.
        if (this.wizardType == "pair") {
          this.wizard.pageIndex = INTRO_PAGE;
          return false;
        }

... (snip)

EXISTING_ACCOUNT_LOGIN_PAGE shows up twice in that snippet for two different cases, the second of which will never be hit.

Tim or Markh, is this old code and can it be deleted? Or should it be kept around and fixed?

Comment 1

[Mark Hammond [:markh] [:mhammond]]

It's effectively dead, but we haven't formally stopped supporting legacy sync for the sake of self-hosters. Within the next 12 months (and possibly even less) we'll kill all of this. So I guess we *should* fix it, yeah.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

We will not fix this - the action here will be to remove that code entirely (if we haven't already)

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

This was actually already fixed by bug 1231728 :)