Closed Bug 1230054 Opened 4 years ago Closed 4 years ago

Remove WebMReader

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox44 --- wontfix
firefox45 --- affected
firefox46 --- fixed

People

(Reporter: jya, Assigned: jya)

Details

Attachments

(1 file)

It's no longer used, and has been disabled since 41.

code can now be removed
Attachment #8695210 - Flags: review?(kinetik)
Assignee: nobody → jyavenard
Attachment #8695210 - Flags: review?(kinetik) → review+
so that means that WebMReader will still in use in some tests and that WebMDemuxer never got proper test coverage :(
That android chrome test is also a desktop chrome test, also failing there, plus desktop mochitest-2: https://treeherder.mozilla.org/logviewer.html#?job_id=18270633&repo=mozilla-inbound
https://hg.mozilla.org/mozilla-central/rev/368534fd8b50
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
bug was there: https://hg.mozilla.org/integration/mozilla-inbound/rev/ce4623289f7f#l6.20
missing GetVideoFrameContainer()

This caused the weirdest crash error on my macbook pro, without static_cast<MediaFormatReader> it would crash, and just timeout with.... likely a bug in clang
https://hg.mozilla.org/mozilla-central/rev/a0d6ae2f0ec3
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.