1230087 - updateReaderButton: tab-content.js, line 337: TypeError: content is null

Status: RESOLVED FIXED

(Firefox Graveyard :: Reading List, defect)

Description

[Jesse Ruderman]

Attachment: testcase (fragile timing)

JavaScript error: chrome://browser/content/tab-content.js, line 337: TypeError: content is null

In bug 1186346, a null check for |content| was added to |get isAboutReader|. Should |updateReaderButton| be fixed in the same way?

>  /**
>   * NB: this function will update the state of the reader button asynchronously
>   * after the next mozAfterPaint call (assuming reader mode is enabled and
>   * this is a suitable document). Calling it on things which won't be
>   * painted is not going to work.
>   */
>  updateReaderButton: function(forceNonArticle) {
>    if (!ReaderMode.isEnabledForParseOnLoad || this.isAboutReader ||
>        !(content.document instanceof content.HTMLDocument) ||
>        content.document.mozSyntheticDocument) {
>      return;
>    }
>
>    this.scheduleReadabilityCheckPostPaint(forceNonArticle);
>  },

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Apologies for the poor commit message, couldn't think of anything more descriptive.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5ce3cd508888

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5ce3cd508888