When customizing localized browsers, script.ib must be modified for the appropriate file names, path names, etc. CCK should create the appropriate script.ib depending upon - platform - language - version (future requirement) These can be created from templates and global substitions. There'll probably need to be templates for each supported platform/version combination. I'll attached a Windows 6.2.1 script.ib template. Here are the some of values for language and region global substitions. (We might want to include more entries for future growth (e.g., Chinese values). Browser Localization <lang> <region> <REGION> ================== ====== ======== ======== English for Canada en ca CA English for UK en uk UK French fr fr FR German de de DE Italian it it IT Japanese ja jp JP Spanish es es ES Swedish sv sv SV
Created attachment 67453 [details] template for CCK 6.2.1 Windows script.ib (updated)
Attachment #67450 - Attachment is obsolete: true
Raising priority since this is a requirement for localized browsers.
Status: NEW → ASSIGNED
Priority: -- → P1
Created attachment 72455 [details] [diff] [review] Patch to dynamically create script.ib for each language This patch allows generating script.ib for each platform/language by replacing the values within '<' and '>' with the appropriate locale values. The existing script_win.ib, script_mac.ib and script_linux.ib will be removed and replaced by script_Windows_template.ib, script_Mac OS_template.ib and script_Linux_template.ib respectively.
I'd like to see a simpler approach than translating a template file. Couldn't you just modify ib to make the appropriate substitutions when it reads the .ib file?
> I'd like to see a simpler approach than translating a template file. Couldn't > you just modify ib to make the appropriate substitutions when it reads the .ib > file? Need more details. Do you mean that we retain the currrent script_win.ib, script_linux.ib as it is. Then, for example if we come across regus in script.ib, replace it with regjp (for japanese) in ib.cpp.
Will be updating patch as per Steve's comments.
Whiteboard: need r=
I'm not sure I understand the comment about template files. Since we want Cecko (in the future) to work with various releases, aren't templates a better solution than hard-coding knowledge about each version of the script.ib files into the Cecko engine?
It'll still use templates. I am simply recommending simplifying the code to eliminate an unneeded intermediate file. I discussed this with Shruti and she understands what I mean and agrees.
Much cleaner. r=smeredith
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Whiteboard: need r=
Verified fixed in 4/9 bld.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.