1230102 - Re-enable functional tests

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

In bug 1214215, I landed a patch that disable almost all of the functional tests.

Note that the failures were not caused by work done in this bug, but because of bug 1229926. Once it's resolved, the tests can be re-enabled.

You can do this manually or by reverting the 'Part 3' commit from bug 1214215.

Comment 1

[Mark Banner (:standard8)]

Didn't realise these were still disabled, given the dependent bugs are fixed, we should try and do this asap.

Comment 2

[Mark Banner (:standard8)]

Attachment: Patch for m-c

Didn't realise this had been disabled for so long, so I'm going to land on m-c and I'll get a pull request up in a moment for landing in the loop repo.

Comment 3

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1230102-func > mozilla:master

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8706385 [details] [diff] [review]
Patch for m-c

Review of attachment 8706385 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM :)

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8706386 [details] [review]
[loop] Standard8:bug-1230102-func > mozilla:master

Same as m-c patch.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2acd89af1dad

Comment 7

[Mark Banner (:standard8)]

https://github.com/Standard8/loop/commit/b8153abe4af8d8bd0ad44b70f62abf958433d1d6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2acd89af1dad