Closed Bug 1230106 Opened 4 years ago Closed 4 years ago
[Static Analysis][Dereference of null pointer] Function DOMSVGPoint
List::Insert Item Before from DOMSVGPoint List .cpp can cause a null pointer dereference
The Static Analysis tool Coverity added that pointer animVal can cause a null pointer dereference on line 324. In this patch i've added a MOZZ_ASSERT, in order to test the pointer validity.
Hello Jonathan, Could you please take a look other this patch. it's just a simple assert on a pointer to signal a potential null pointer dereference. THX
Attachment #8695230 - Flags: review?(jwatt)
Comment on attachment 8695230 [details] [diff] [review] Bug 1230106.diff stealing as this is my code. MOZ_ASSERT(animVal, "AnimListMirrorsBaseList() promised a non-null animVal"); would be better but the text doesn't matter that much.
Attachment #8695230 - Flags: review?(jwatt) → review+
You need to log in before you can comment on or make changes to this bug.