1230118 - [Static Analysis][Dereference Null Return Value] In function DocAccessible::DoARIAOwnsRelocation from DocAccessible.cpp

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that aOwner->Elm() can return a null pointer that later in function IDRefsIterator(DocAccessible*, nsIContent*,                 nsIAtom*) can cause a null pointer dereference.

Comment 1

[Andi [:andi]]

Attachment: Bug 1230118.diff

Hello Alexander,

Could you please take a look other this patch?

THX

Comment 2

[Andi [:andi]]

thank you for the review, i've marked the bug in checkin-needed.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ce85f77af9

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ce85f77af9

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Bogdan, could you please add your username information to your .hgrc file as described in https://developer.mozilla.org/en-US/docs/Installing_Mercurial#Basic_configuration ? It would make checking in these patches much easier in the future.

Comment 6

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00a155011747

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87ea4e496d96

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Accidentally backed this out. Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/87ea4e496d96

Sorry about that.

Comment 9

[Andi [:andi]]

Hello Wes,

Thnaks for that, i did that change, it seemed to be an issue with my TortoiseHG

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/87ea4e496d96