[Static Analysis][Dereference Null Return Value] In function DocAccessible::DoARIAOwnsRelocation from DocAccessible.cpp

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla45
coverity
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

(Whiteboard: CID 1338375)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The Static Analysis tool Coverity added that aOwner->Elm() can return a null pointer that later in function IDRefsIterator(DocAccessible*, nsIContent*,                 nsIAtom*) can cause a null pointer dereference.
(Assignee)

Updated

3 years ago
Whiteboard: CID 1338375
(Assignee)

Comment 1

3 years ago
Created attachment 8695242 [details] [diff] [review]
Bug 1230118.diff

Hello Alexander,

Could you please take a look other this patch?

THX
Attachment #8695242 - Flags: review?(surkov.alexander)
Attachment #8695242 - Flags: review?(surkov.alexander) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

3 years ago
thank you for the review, i've marked the bug in checkin-needed.
(Assignee)

Updated

3 years ago
Blocks: 1230156
Bogdan, could you please add your username information to your .hgrc file as described in https://developer.mozilla.org/en-US/docs/Installing_Mercurial#Basic_configuration ? It would make checking in these patches much easier in the future.
Flags: needinfo?(bogdan.postelnicu)
Accidentally backed this out. Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/87ea4e496d96

Sorry about that.
(Assignee)

Comment 9

3 years ago
Hello Wes,

Thnaks for that, i did that change, it seemed to be an issue with my TortoiseHG
Flags: needinfo?(bogdan.postelnicu)

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/87ea4e496d96
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.