Closed Bug 1230118 Opened 4 years ago Closed 4 years ago

[Static Analysis][Dereference Null Return Value] In function DocAccessible::DoARIAOwnsRelocation from DocAccessible.cpp

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1338375)

Attachments

(1 file)

The Static Analysis tool Coverity added that aOwner->Elm() can return a null pointer that later in function IDRefsIterator(DocAccessible*, nsIContent*,                 nsIAtom*) can cause a null pointer dereference.
Whiteboard: CID 1338375
Attached patch Bug 1230118.diffSplinter Review
Hello Alexander,

Could you please take a look other this patch?

THX
Attachment #8695242 - Flags: review?(surkov.alexander)
Attachment #8695242 - Flags: review?(surkov.alexander) → review+
Keywords: checkin-needed
thank you for the review, i've marked the bug in checkin-needed.
Bogdan, could you please add your username information to your .hgrc file as described in https://developer.mozilla.org/en-US/docs/Installing_Mercurial#Basic_configuration ? It would make checking in these patches much easier in the future.
Flags: needinfo?(bogdan.postelnicu)
Hello Wes,

Thnaks for that, i did that change, it seemed to be an issue with my TortoiseHG
Flags: needinfo?(bogdan.postelnicu)
https://hg.mozilla.org/mozilla-central/rev/87ea4e496d96
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.