1230143 - [Messages] Exception "TypeError: messagesContainer is null" is thrown when user tries to manually download MMS

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

STR:
1. Connect to device with WebIDE and open console;
2. Disable auto MMS retrieval in Settings and receive MMS;
3. Tap on "Download" link;
4. Observe console log.

Expected result: nothing bad should be here!

Actual result: Unhandled exception is thrown ("TypeError: messagesContainer is null")

There is no any effect on user here, hence priority is very low. This happens because of the fact that sometimes "message-received" event is received before "MessagingClient.retrieveMMS" returns result (became more apparent after relying on bridge for this operation). So onMessageReceived handler calls "appendMessage" that removes message node and "retrieveMMS" success handler tries to remove this node as well.

So if downloaded MMS always has the same id (I believe it's the case), we can stop trying to remove message node in "retrieveMMS" success callback and entirely rely on onMessageReceived handler to do the job. Additionally "appendMessage" can swap nodes instead of remove-add operation.

Comment 1

[kumar rishav (:rishav_)]

By mistake, it got removed. Sorry

Comment 2

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 3

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(