Closed Bug 1230149 Opened 8 years ago Closed 8 years ago

[Static Analysis][Dereference After Null Check] Function ContentHostTexture::Composite from ContentHost.cpp

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1338370)

Attachments

(1 file)

Bug 1230149.diff
1.03 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
The Static Analysis tool Coverity added that bigImgIter when it's null can be null pointer dereferenced in:

138    if (iterOnWhite) {
139      MOZ_ASSERT(iterOnWhite->GetTileRect() == bigImgIter->GetTileRect(),
140                 "component alpha textures should be the same size.");
141    }
Whiteboard: CID 1338370
Attached patch Bug 1230149.diff — — Splinter Review 
Hello Jeff,

Could you please take a look other this patch?

THX
Attachment #8695292 - Flags: review?(jmuizelaar)
Blocks: coverity-analysis
Attachment #8695292 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ecdefe80c366
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.