[Static Analysis][Dereference After Null Check] Function ContentHostTexture::Composite from ContentHost.cpp

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla45
coverity
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

(Whiteboard: CID 1338370)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The Static Analysis tool Coverity added that bigImgIter when it's null can be null pointer dereferenced in:

138    if (iterOnWhite) {
139      MOZ_ASSERT(iterOnWhite->GetTileRect() == bigImgIter->GetTileRect(),
140                 "component alpha textures should be the same size.");
141    }
(Assignee)

Updated

3 years ago
Whiteboard: CID 1338370
(Assignee)

Comment 1

3 years ago
Created attachment 8695292 [details] [diff] [review]
Bug 1230149.diff

Hello Jeff,

Could you please take a look other this patch?

THX
Attachment #8695292 - Flags: review?(jmuizelaar)
(Assignee)

Updated

3 years ago
Blocks: 1230156
Attachment #8695292 - Flags: review?(jmuizelaar) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ecdefe80c366
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.