Closed Bug 1230149 Opened 4 years ago Closed 4 years ago

[Static Analysis][Dereference After Null Check] Function ContentHostTexture::Composite from ContentHost.cpp

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1338370)

Attachments

(1 file)

The Static Analysis tool Coverity added that bigImgIter when it's null can be null pointer dereferenced in:

138    if (iterOnWhite) {
139      MOZ_ASSERT(iterOnWhite->GetTileRect() == bigImgIter->GetTileRect(),
140                 "component alpha textures should be the same size.");
141    }
Whiteboard: CID 1338370
Attached patch Bug 1230149.diffSplinter Review
Hello Jeff,

Could you please take a look other this patch?

THX
Attachment #8695292 - Flags: review?(jmuizelaar)
Attachment #8695292 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ecdefe80c366
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.