1230151 - Skip out-of-sync messages in Marionette Python client

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Following the introduction of message sequencing for Marionette in bug 1211489, we can now switch on skipping out-of-sync messages which will help avoid issues such as bug 1207125.

Comment 1

[Andreas Tolfsen ❲:ato❳]

I added tests for this as part of bug 1211503 but apparently the custom skip decorator has a bug and makes the test always pass: https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/tests/unit/test_transport.py?from=test_transport.py#18

The bug is that it returns "self", that is a reference to itself, rather than invoking self.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Bug 1230151: Part 1: Fix skip_unless_protocol ignore decorator

This decorator was previously returning a reference of itself, rather
than executing the test item.  This caused it to always pass.

r=dburns

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1230151 - Skip out of sync messages in Marionette client;

Bug 1230151: Part 2: Skip out of sync messages in Marionette client

The Marionette remote server sequences messages following bug 1211489.
In the client we can make advantage of this by skipping out-of-sync
messages.

This helps avoid issues such as bug 1207125, where a Python process
interrupt causes the receive() for the current command to be aborted,
and a new command to be issued to retrieve some debug information.
When the new command's receive() is called, it reads the response from
the previous command.

To get around this problem we must read through the data until we reach
the response we are expecting.  Only at that point should we return from
receive() and give the user the expected response.

r=dburns

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/1-2/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/1-2/

Comment 6

[David Burns :automatedtester]

Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

https://reviewboard.mozilla.org/r/27205/#review24593

Comment 7

[David Burns :automatedtester]

Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

https://reviewboard.mozilla.org/r/27207/#review24595

Comment 8

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=86510b524e30

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/1-2/

Comment 10

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/1-2/

Comment 11

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/2-3/

Comment 12

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/2-3/

Comment 13

[David Burns :automatedtester]

What is needed for this to land?

Comment 14

[Andreas Tolfsen ❲:ato❳]

Test failures that must be investigated.  Not on the top of my list right now, but I will eventually get to this.

Comment 15

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/3-4/

Comment 16

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/3-4/

Comment 17

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/4-5/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/039f4a14bdfb
Fix skip_unless_protocol ignore decorator; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/d37f21fd493c
Skip out of sync messages in Marionette client; r=automatedtester

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/039f4a14bdfb
https://hg.mozilla.org/mozilla-central/rev/d37f21fd493c

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3233a69a1ce8
https://hg.mozilla.org/releases/mozilla-aurora/rev/a38dbd94a596

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.