Skip out-of-sync messages in Marionette Python client

RESOLVED FIXED in Firefox 50

Status

Testing
Marionette
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks: 1 bug, {ateam-marionette-client})

unspecified
mozilla51
ateam-marionette-client
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed, firefox51 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Following the introduction of message sequencing for Marionette in bug 1211489, we can now switch on skipping out-of-sync messages which will help avoid issues such as bug 1207125.
(Assignee)

Updated

2 years ago
Blocks: 1207125
Depends on: 1211489
(Assignee)

Updated

2 years ago
Keywords: ateam-marionette-client
(Assignee)

Comment 1

2 years ago
I added tests for this as part of bug 1211503 but apparently the custom skip decorator has a bug and makes the test always pass: https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/tests/unit/test_transport.py?from=test_transport.py#18

The bug is that it returns "self", that is a reference to itself, rather than invoking self.
(Assignee)

Updated

2 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Summary: Skip out-of-sync messages → Skip out-of-sync messages in Marionette Python client
(Assignee)

Comment 2

2 years ago
Created attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Bug 1230151: Part 1: Fix skip_unless_protocol ignore decorator

This decorator was previously returning a reference of itself, rather
than executing the test item.  This caused it to always pass.

r=dburns
(Assignee)

Comment 3

2 years ago
Created attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Bug 1230151: Part 2: Skip out of sync messages in Marionette client

The Marionette remote server sequences messages following bug 1211489.
In the client we can make advantage of this by skipping out-of-sync
messages.

This helps avoid issues such as bug 1207125, where a Python process
interrupt causes the receive() for the current command to be aborted,
and a new command to be issued to retrieve some debug information.
When the new command's receive() is called, it reads the response from
the previous command.

To get around this problem we must read through the data until we reach
the response we are expecting.  Only at that point should we return from
receive() and give the user the expected response.

r=dburns
(Assignee)

Updated

2 years ago
Attachment #8695841 - Flags: review?(dburns)
(Assignee)

Comment 4

2 years ago
Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/1-2/
(Assignee)

Comment 5

2 years ago
Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/1-2/
Attachment #8695842 - Flags: review?(dburns)
Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

https://reviewboard.mozilla.org/r/27205/#review24593
Attachment #8695841 - Flags: review?(dburns) → review+
Attachment #8695842 - Flags: review?(dburns) → review+
Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

https://reviewboard.mozilla.org/r/27207/#review24595
(Assignee)

Comment 8

2 years ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=86510b524e30
(Assignee)

Comment 9

2 years ago
Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/1-2/
(Assignee)

Comment 10

2 years ago
Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/1-2/
(Assignee)

Comment 11

2 years ago
Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/2-3/
Attachment #8695841 - Attachment description: MozReview Request: Bug 1230151: Part 1: Fix skip_unless_protocol ignore decorator → MozReview Request: Bug 1230151 - Fix skip_unless_protocol ignore decorator; r?automatedtester
(Assignee)

Comment 12

2 years ago
Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/2-3/
Attachment #8695842 - Attachment description: MozReview Request: Bug 1230151: Part 2: Skip out of sync messages in Marionette client → MozReview Request: Bug 1230151 - Skip out of sync messages in Marionette client; r?automatedtester
What is needed for this to land?
Flags: needinfo?(ato)
(Assignee)

Comment 14

2 years ago
Test failures that must be investigated.  Not on the top of my list right now, but I will eventually get to this.
Flags: needinfo?(ato)
(Assignee)

Comment 15

a year ago
Comment on attachment 8695841 [details]
Bug 1230151 - Fix skip_unless_protocol ignore decorator;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27205/diff/3-4/
Attachment #8695841 - Attachment description: MozReview Request: Bug 1230151 - Fix skip_unless_protocol ignore decorator; r?automatedtester → Bug 1230151 - Fix skip_unless_protocol ignore decorator;
Attachment #8695842 - Attachment description: MozReview Request: Bug 1230151 - Skip out of sync messages in Marionette client; r?automatedtester → Bug 1230151 - Skip out of sync messages in Marionette client;
(Assignee)

Comment 16

a year ago
Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/3-4/
(Assignee)

Comment 17

a year ago
Comment on attachment 8695842 [details]
Bug 1230151 - Skip out of sync messages in Marionette client;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27207/diff/4-5/

Comment 18

a year ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/039f4a14bdfb
Fix skip_unless_protocol ignore decorator; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/d37f21fd493c
Skip out of sync messages in Marionette client; r=automatedtester

Comment 19

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/039f4a14bdfb
https://hg.mozilla.org/mozilla-central/rev/d37f21fd493c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
https://hg.mozilla.org/releases/mozilla-aurora/rev/3233a69a1ce8
https://hg.mozilla.org/releases/mozilla-aurora/rev/a38dbd94a596
status-firefox50: --- → fixed
You need to log in before you can comment on or make changes to this bug.