1230163 - Text copied from plain-text Message Composition window loses formatting

Status: RESOLVED FIXED

(Core :: DOM: Serializers, defect)

Description

[Mason]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39
Build ID: 20151103191810

Steps to reproduce:

1. Open a plain-text Message Composition (MC) window (CTRL-M)
2. Write some text with multiple spaces, e.g.
000000
  1 1 1 1 1 1
   2  2  2  2  2  2
    3   3   3   3   3   3
     4    4    4    4    4    4
      5     5     5     5     5     5

3. Highlight all text in MC window (CTRL-A)
4. Copy the highlighted text (CTRL-C)
5. Paste the text anywhere (CTRL-V)

All formatting is lost:
000000
1 1 1 1 1 1
2 2 2 2 2 2
3 3 3 3 3 3
4 4 4 4 4 4
5 5 5 5 5 5

Comment 1

[Mason]

Issue was confirmed by Paul B. Gallagher in mozilla.support.seamonkey

Date: Wed, 2 Dec 2015 17:38:21 -0500
Message-ID: <[e-mail]>

The symptoms are reminiscent of bug 625961.

Comment 2

[Ant]

Easy to reproduce in my SeaMonkey v2.39 in Windows XP Pro SP3. Voted. :)

Comment 3

[Rainer Bielefeld]

I am pretty sure that we already have a bug for that, I will check later

Comment 4

[Rainer Bielefeld]

Description here sounds very similar to "Bug 1195223 - space characters missing after copy & paste", what itself is a DUP of "Bug 1193153 - Copy/paste from a plain text editor loses white-space (multiple spaces/blanks, tabs, newlines) since plain text editor uses "white-space: pre-wrap" - Caused by bug 1174452 "

@Reporter: Please feel free to reopen this Bug if you find out that the fix for the other bug does not solve your problem or if you see other well founded indication that you fond an independent bug.

Comment 5

[Mason]

Rainer,

IIUC, the bug is fixed in TB45.
And TB45 <-> SM 2.42 (to be released in 14 weeks)
Correct?

Comment 6

[Rainer Bielefeld]

Yes. But I don't know when exactly TB bugfixes reach SeaMonkey code.

Comment 7

[Mason]

Bug 1193153 was fixed, but ONLY for Thunderbird.

@Seamonkey MailNews maintainers: Bug 1193153 comment 45 states what needs to be done to fix the problem in Seamonkey.
However, the fix may cause regressions in the browser part. What do you think?

Comment 8

[Jorg K (CEST = GMT+2)]

OK, let's reopen this for SM.

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: conditional compilation also for SeaMonkey

Turns out that the SeaMonkey people also want this fixed. Ehsan, could you please approve. I know how much you hate it, you've said so in bug 1214377 comment #19.

Comment 10

[Mason]

@Jorg, Ehsan is marked "Away 2/10-2/19".
Are you hoping he might have time to look at it today?

Comment 11

[Jorg K (CEST = GMT+2)]

Dear Sheriff,
this is a trivial one-line change which does not affect Firefox at all:
-#ifdef MOZ_THUNDERBIRD
+#if defined(MOZ_THUNDERBIRD) || defined(MOZ_SUITE)

Please land with some other patches to avoid needless testing. There is no hurry, the patch can wait a few days if necessary.

Thank you.

Comment 12

[Jorg K (CEST = GMT+2)]

Moved this to Core::Serializers so the sheriffs will see it.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88e44bfba483

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/88e44bfba483

Comment 15

[Mason]

Target Milestone: mozilla47

This means Gecko 47? So SeaMonkey 2.44?

https://wiki.mozilla.org/Releases
I see ewong posted an alpha 2.44 last week.

@ewong, will this patch automatically be picked up in the next alpha/beta?

Comment 16

[Tony Mechelynck [:tonymec]]

(In reply to Mason from comment #15)
> Target Milestone: mozilla47
> 
> This means Gecko 47? So SeaMonkey 2.44?

Yes.

> https://wiki.mozilla.org/Releases
> I see ewong posted an alpha 2.44 last week.
> 
> @ewong, will this patch automatically be picked up in the next alpha/beta?

It is already in the next 2.44a1 after comment #14 (but your guess is as good as mine about when it will be built).

It will be in beta when M47/Sm2.44 becomes beta (in three months or so) or earlier if the fix is manually ported to mozilla 46 or 45.