Closed Bug 1230220 Opened 4 years ago Closed 4 years ago

Convert JS callsites to use asyncOpen2 within modules/

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → mozilla
Blocks: 1182535
Status: NEW → ASSIGNED
Comment on attachment 8695354 [details] [diff] [review]
bug_1230220_asyncopen2_modules.patch

Review of attachment 8695354 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed.

::: modules/libjar/test/unit/test_bug370103.js
@@ +15,3 @@
>  
>    // Try opening channel with null listener
> +  var channel = NetUtil.newChannel({uri: url, loadUsingSystemPrincipal: true});

No need to create a URI object here. Simply pass the string to NetUtil.newChannel

Same in all other callsites in this patch
Attachment #8695354 - Flags: review?(jonas) → review+
Flags: needinfo?(mozilla)
https://hg.mozilla.org/mozilla-central/rev/af6a998f3d7e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.