Talos should exit early on TART timeout

RESOLVED FIXED in Firefox 45

Status

Testing
Talos
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: parkouss, Assigned: parkouss)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Right now when we have a TART timeout (see bug 1052467) the jobs takes more than an hour to complete, and 50 minutes are spent waiting for the process to finish (example, https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=2797880).

We should exit talos on error as soon as the TART timeout is detected.
(Assignee)

Comment 1

2 years ago
Created attachment 8695361 [details]
MozReview Request: Bug 1230223 - Talos should exit early on TART timeout. r=jmaher

Bug 1230223 - Talos should exit early on TART timeout. r=jmaher
Attachment #8695361 - Flags: review?(jmaher)
Comment on attachment 8695361 [details]
MozReview Request: Bug 1230223 - Talos should exit early on TART timeout. r=jmaher

https://reviewboard.mozilla.org/r/27079/#review24483

this looks great!
Attachment #8695361 - Flags: review?(jmaher) → review+
(Assignee)

Comment 3

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2da26e31e1a
(Assignee)

Comment 4

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5e8d2824054
(Assignee)

Comment 5

2 years ago
This last try is good - we now fail early with that patch.
(Assignee)

Comment 6

2 years ago
Created attachment 8695739 [details] [diff] [review]
talos_tart_timeout.patch

So, this is the patch reviewed by :jmaher (with a addition of one line to make it work!) - we discussed that on irc, so moving the r+ from my previous patch.
Attachment #8695361 - Attachment is obsolete: true
Attachment #8695739 - Flags: review+
(Assignee)

Comment 7

2 years ago
Inbound is closed right now, asking for checkin-needed.
Keywords: checkin-needed

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b57cc7221eec
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b57cc7221eec
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.