Closed Bug 1230234 Opened 4 years ago Closed 4 years ago

client auth leaks a certificate reference

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR: run firefox with NSPR_LOG_MODULES=pipnss:5, visit a site that uses client certificate auth. After closing firefox, the string "NSS SHUTDOWN FAILURE" will probably be in the log output. This is due to a CERTCertificate getting addref'd at least once more than it gets released.
Assignee: nobody → dkeeler
bug 1230234 - fix a leak in client auth certificate handling r?Cykesiopka

Looks like this was essentially a copy/paste error. See changeset 04b4ea333800.
(Note that the bug number annotation in that commit message is incorrect, so
it's anyone's guess as to which bug this actually changed in.)
Attachment #8695493 - Flags: review?(cykesiopka.bmo)
Attachment #8695493 - Flags: review?(cykesiopka.bmo) → review+
Comment on attachment 8695493 [details]
MozReview Request: bug 1230234 - fix a leak in client auth certificate handling r?Cykesiopka

https://reviewboard.mozilla.org/r/27133/#review24585

LGTM.

> Looks like this was essentially a copy/paste error. See changeset 04b4ea333800.
> (Note that the bug number annotation in that commit message is incorrect, so
> it's anyone's guess as to which bug this actually changed in.)

Hmm, looks like https://bugzilla.mozilla.org/attachment.cgi?id=569566&action=edit from Bug 675221.
(I cheated and used a search engine).

https://bugzilla.mozilla.org/attachment.cgi?id=565408&action=edit looks like an earlier version, and that uses a CERTCertificateCleaner.
Probably a copy/paste error like you said - I skimmed through and didn't see any other reason.
Thanks for the review.

(In reply to Cykesiopka from comment #2)
> Hmm, looks like
> https://bugzilla.mozilla.org/attachment.cgi?id=569566&action=edit from Bug
> 675221.
> (I cheated and used a search engine).

Nice find!
https://hg.mozilla.org/mozilla-central/rev/7e074f315a92
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.