1230234 - client auth leaks a certificate reference

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

STR: run firefox with NSPR_LOG_MODULES=pipnss:5, visit a site that uses client certificate auth. After closing firefox, the string "NSS SHUTDOWN FAILURE" will probably be in the log output. This is due to a CERTCertificate getting addref'd at least once more than it gets released.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: MozReview Request: bug 1230234 - fix a leak in client auth certificate handling r?Cykesiopka

bug 1230234 - fix a leak in client auth certificate handling r?Cykesiopka

Looks like this was essentially a copy/paste error. See changeset 04b4ea333800.
(Note that the bug number annotation in that commit message is incorrect, so
it's anyone's guess as to which bug this actually changed in.)

Comment 2

[:Cykesiopka]

Comment on attachment 8695493 [details]
MozReview Request: bug 1230234 - fix a leak in client auth certificate handling r?Cykesiopka

https://reviewboard.mozilla.org/r/27133/#review24585

LGTM.

> Looks like this was essentially a copy/paste error. See changeset 04b4ea333800.
> (Note that the bug number annotation in that commit message is incorrect, so
> it's anyone's guess as to which bug this actually changed in.)

Hmm, looks like https://bugzilla.mozilla.org/attachment.cgi?id=569566&action=edit from Bug 675221.
(I cheated and used a search engine).

https://bugzilla.mozilla.org/attachment.cgi?id=565408&action=edit looks like an earlier version, and that uses a CERTCertificateCleaner.
Probably a copy/paste error like you said - I skimmed through and didn't see any other reason.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks for the review.

(In reply to Cykesiopka from comment #2)
> Hmm, looks like
> https://bugzilla.mozilla.org/attachment.cgi?id=569566&action=edit from Bug
> 675221.
> (I cheated and used a search engine).

Nice find!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e074f315a92

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e074f315a92