123024 - Special-case zero when about to call GetMinimumWidgetsize

Status: RESOLVED INVALID

(Core :: XUL, defect)

Description

[Mike Pinkerton (not reading bugmail)]

There are cases where gecko wants to draw a widget with no dimensions (such as
the tree headers in the autocomplete widget). however, it asks the theme impl
what the minimum height is and it comes back with soemthing like 15, resulting
in the headers being shown inappropriately.

The code that calls GetMinimumWidgetSize needs to special-case zero and probably
not ask the theme impl if that is what is desired.

Comment 1

[David Hyatt]

Well, I think it would be more accurate to say that the autocomplete widget 
is buggy.  It should be collapsing its headers rather than explicitly putting 
the height of the headers to 0.

Comment 2

[David Hyatt]

A collapsed element will not show, regardless of what the theme says, so 
I think that's the way to fix this.

Comment 3

[Mike Pinkerton (not reading bugmail)]

humm, ok, so should the bug be on the autocomplete widget and this should be
closed out as invalid?

Comment 4

[David Hyatt]

I think so, yeah.

Comment 5

[Mike Pinkerton (not reading bugmail)]

per discussion

Comment 6

[John Morrison]

Er, I'm assuming 'per discussion' expands to 'filed bug 123028 on autocomplete, 
and marking this bug invalid'. :-]