Open
Bug 1230243
Opened 8 years ago
Updated 2 years ago
fix leaks when adding password inputs to documents
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
NEW
People
(Reporter: froydnj, Unassigned)
References
Details
Attachments
(1 file)
1.69 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•8 years ago
|
||
Noticed when looking at other things...
Attachment #8695397 -
Flags: review?(bugs)
Reporter | ||
Comment 2•8 years ago
|
||
On further inspection, this doesn't actually leak, but it's an odd coding pattern when compared to every other instead of AsyncEventDispatcher. It also seems inefficient to do: RefPtr<AED> d = new AED(...) d->PostDOMEvent(); which takes another reference and then passes it into NS_DispatchToCurrentThread, which will take yet another ref...and then we'll unwind the previous references. We ought to be able to make that pattern more efficient.
Reporter | ||
Updated•8 years ago
|
tracking-firefox44:
? → ---
tracking-firefox45:
? → ---
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #2) > It also seems inefficient to do: > > RefPtr<AED> d = new AED(...) > d->PostDOMEvent(); Filed bug 1230259 for this.
Comment 4•8 years ago
|
||
Comment on attachment 8695397 [details] [diff] [review] fix leaks when adding password inputs to documents I guess better to just change everyone to use static methods (that other bug), since currently this pattern is explicitly supported - PostDOMEvent() addref/releases.
Attachment #8695397 -
Flags: review?(bugs)
Assignee | ||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Comment 5•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: froydnj+bz → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•