Open Bug 1230243 Opened 8 years ago Updated 2 years ago

fix leaks when adding password inputs to documents

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file)

      No description provided.
Noticed when looking at other things...
Attachment #8695397 - Flags: review?(bugs)
On further inspection, this doesn't actually leak, but it's an odd coding pattern when compared to every other instead of AsyncEventDispatcher.

It also seems inefficient to do:

RefPtr<AED> d = new AED(...)
d->PostDOMEvent();

which takes another reference and then passes it into NS_DispatchToCurrentThread, which will take yet another ref...and then we'll unwind the previous references.  We ought to be able to make that pattern more efficient.
Blocks: 1132211
(In reply to Nathan Froyd [:froydnj] from comment #2)
> It also seems inefficient to do:
> 
> RefPtr<AED> d = new AED(...)
> d->PostDOMEvent();

Filed bug 1230259 for this.
Comment on attachment 8695397 [details] [diff] [review]
fix leaks when adding password inputs to documents

I guess better to just change everyone to use static methods (that other bug), since currently
this pattern is explicitly supported - PostDOMEvent() addref/releases.
Attachment #8695397 - Flags: review?(bugs)
Component: DOM → DOM: Core & HTML

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: froydnj+bz → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: