1230267 - Inconsistent display of SVG title as tooltip when multi-process is enabled

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[dprice]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/601.2.7 (KHTML, like Gecko) Version/9.0.1 Safari/601.2.7

Steps to reproduce:

When an SVG g element contains both a title and a shape such as a rect, the content of the title element is not drawn as a tooltip if multi-process Firefox is enabled. Per https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title I would expect the title to be displayed as a tooltip. When multi-process is disabled or the title element is the child of the shape itself, the tooltip is displayed as expected.


this bug occurs in FF nightly 45.0a1 (2015-12-03) and FF Developer Edition 44.0a2 (2015-12-03) on Windows 10 and OS X 10.11


1. Enable multi-process Firefox
2. Open test case: http://codepen.io/daleprice/pen/MKgNRq
3. Hover over the red rectangle on the left


Actual results:

No tooltip is displayed over the red rectangle (which has the title element as the first child of the g element), but a tooltip is displayed over the green rectangle (which has the title element as the child of the rect element).


Expected results:

A tooltip should have been displayed when hovering over both rectangles.

Comment 1

[dprice]

The build ID of the nightly I found this in is 20151203053521

Comment 2

[Michelle Funches - QA]

Confirmed
20151204030208
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Firefox/45.0

Comment 3

[Robert Longson [:longsonr]]

Attachment: fix wrong variable

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 8701851 [details] [diff] [review]
fix wrong variable

Patch looks good, but can we pleaase add a test for this as well so that we ensure this doesn't regress again?

Thanks!

Comment 5

[Robert Longson [:longsonr]]

Any suggestions as to how I might write a test for this? Writing a complete c++ program, creating a bunch of nsDOMINodes somehow and calling the method seems overkill. I'm not sure how the browser does it? Can I plug into that? There's a remoteBrowserTooltip but I'm not sure that's the right thing or even how to use it if it is.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd6b93ff2af7

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cd6b93ff2af7

Comment 8

[Johnny Stenback (:jst)]

jwatt, can you help advice on how we could write a mochitest for this?

Comment 9

[Jonathan Watt [:jwatt]]

Seems like this should be possible in principle using DOMWindowUtils and then checking the tooltip text in the parent process, but that seems like it would be quite subject to intermittent failures.

Comment 10

[Jonathan Watt [:jwatt]]

Gijs notes that the new tab tests do something like this (moving tabs around with "real" mouse events) and suggests drilling down from https://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/newtab/browser_newtab_drag_drop.js