1230305 - Holiday file of holidays in India 2016

Status: RESOLVED FIXED

(Calendar :: Website, enhancement)

Description

[seshu.parvataneni]

Attachment: IndiaHolidays.ics

+++ This bug was initially created as a clone of Bug #942608 +++

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 SeaMonkey/2.19 (Beta/Release)
Build ID: 20130630011339

Steps to reproduce:

Provide holiday file for holidays in India. The locale is US English and most of it is valid of a couple of years. However, some events follow the lunar calendar and require yearly updates.

Reproducible: Always

Steps to Reproduce:
N/A
Actual Results:  
N/A

Expected Results:  
N/A

Please see attached ICS file for holidays in India.

Comment 1

[seshu.parvataneni]

Tested with 

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 Lightning/4.4b2

Thanks.

Comment 2

[seshu.parvataneni]

Hi,

Can someone please link this ics file to the ics file for India listed on https://www.mozilla.org/en-US/projects/calendar/holidays. Thanks.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Can you correct the file regarding timezones? For example:

DTSTART;VALUE=DATE;TZID=America/Los_Angeles:20161010

should be:

DTSTART;VALUE=DATE:20161010

because DATE values don't have a timezone.

Comment 4

[seshu.parvataneni]

Attachment: The holiday file with the fixed TZ field

Thanks for the feedback. I have removed the TZ field. Please review and let me know if any more changes are required.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Link to github pull request

Thanks. I've removed the unneeded America/Los_Angeles timezone that was already there before, but aside from that it is good.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Let's leave this open until the pull request is merged, the robot will automatically resolve the issue then.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Looks like it only resolves the first bug.

https://github.com/mozilla/bedrock/commit/113a3dd597a65942d1526617bf886146bda136ae