Closed Bug 1230324 Opened 4 years ago Closed 4 years ago

Hamburger menu styling details

Categories

(Thunderbird :: Theme, defect, minor)

defect
Not set
minor

Tracking

(thunderbird45 fixed, thunderbird46 fixed)

RESOLVED FIXED
Thunderbird 46.0
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed

People

(Reporter: aleth, Assigned: Paenglab)

Details

Attachments

(2 files)

Attached image hamburger.png
Compared with Firefox, the Hamburger button in TB is missing some margin on the right, and a separator on the left.
The margin can be done but the separator could be harder because on TB the button can be moved on the toolbars.
(In reply to Richard Marti (:Paenglab) from comment #1)
> The margin can be done but the separator could be harder because on TB the
> button can be moved on the toolbars.

Ah OK, the separator probably isn't worth the added complexity then.
Why not just make the default toolbar items include a separator in the appropriate spot?
This makes the AppButton having the same spacing on all platforms. I have no left separator added because 1. our button is movable and hardcoding it would make it complicated to program, and 2. I think it is not needed because the search box splits enough and a separator isn't looking good beside this box.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8699104 - Flags: review?(aleth)
Attachment #8699104 - Flags: review?(aleth) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/85b97de5e1de4bf53d6db5c9a273b76c5d4b68d5
Bug 1230324 - Add margins to the AppMenu button to make it the same width as on FX. r=aleth
You might want to uplift these and the other styling improvements to 45.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment on attachment 8699104 [details] [diff] [review]
appMenuButton.patch

[Approval Request Comment]
User impact if declined: no impact
Testing completed (on c-c, etc.): in c-c
Risk to taking this patch (and alternatives if risky): low, only style adjustment through CSS
Attachment #8699104 - Flags: approval-comm-aurora?
Attachment #8699104 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.