Closed
Bug 1230352
Opened 8 years ago
Closed 8 years ago
[webvr] Add support for Oculus 0.8 runtime
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: kip, Assigned: kip)
References
Details
Attachments
(1 file)
46.78 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
This replaces support for the Oculus 0.6 runtime with Oculus 0.8 runtime support.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8695563 -
Flags: review?(vladimir)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=14ff84f89bae
Comment on attachment 8695563 [details] [diff] [review] Bug 1230352 - Update to Oculus SDK 0.8.0 What does this patch apply to? Stuff like -HMDInfoOculus::HMDInfoOculus(ovrHmd aHMD, bool aDebug, int aDeviceID) +HMDInfoOculus::HMDInfoOculus(ovrSession aSession) : VRHMDInfo(VRHMDType::Oculus, false) - , mHMD(aHMD) - , mTracking(false) - , mDebug(aDebug) - , mDeviceID(aDeviceID) - , mSensorTrackingFramesRemaining(0) + , mSession(aSession) is not currently in the tree. So this has prereqs?
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #3) > Comment on attachment 8695563 [details] [diff] [review] > Bug 1230352 - Update to Oculus SDK 0.8.0 > > What does this patch apply to? Stuff like > > -HMDInfoOculus::HMDInfoOculus(ovrHmd aHMD, bool aDebug, int aDeviceID) > +HMDInfoOculus::HMDInfoOculus(ovrSession aSession) > : VRHMDInfo(VRHMDType::Oculus, false) > - , mHMD(aHMD) > - , mTracking(false) > - , mDebug(aDebug) > - , mDeviceID(aDeviceID) > - , mSensorTrackingFramesRemaining(0) > + , mSession(aSession) > > is not currently in the tree. So this has prereqs? This applies on top of the patch set for Bug 1182048 (Make WebVR and e10s work together)
Attachment #8695563 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0814f2d30eda6175980be9318b8ed4a7fccaf435 Bug 1230352 - Update to Oculus SDK 0.8.0,r=vlad
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0814f2d30eda
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•