1230400 - Assertion failure: mLoadGroup, at dom/fetch/FetchDriver.cpp:245

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

1. Allow popups from testcase
2. Load testcase
3. Wait 17 seconds (!)

Assertion failure: mLoadGroup, at dom/fetch/FetchDriver.cpp:245

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Jonas, did you just add this assert?  I seem to recall you changed a load group check to an assert recently.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

That assertion seems to have been there since before any of my changes.

http://hg.mozilla.org/mozilla-central/annotate/528fc18a86d3/dom/fetch/FetchDriver.cpp#l245

I'm changing the assert in bug 1224800 though.

However the assert seems valid. We should always have a loadgroup when a request from a webpage does a network request. Not having a loadgroup is a waste of resources at worst (since we won't cancel the network request when the user leaves the page), and a security issue at worst (can use the wrong cookies).

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

So maybe this is about doing a fetch using a dead global.  We should just reject immediately on that.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Ben Kelly [:bkelly] from comment #4)
> So maybe this is about doing a fetch using a dead global.  We should just
> reject immediately on that.

Errr... not a dead global.

Comment 6

[Jesse Ruderman]

I'm curious why the testcase has to wait 17 seconds. I tried doing a MP (GC+CC+...) instead, but that didn't trip the assertion.

Comment 7

[Andrei Purice]

Hey Jesse,
Can you still repro this or should we close it?

Comment 8

[Peter Magyari (Desktop QA)]

Since this issue has been open for so long without a resolution and we cannot reproduce it ourselves I'm going to close it for now.
If the issue is still reproducible on the latest Firefox versions however, please feel free to re-open it.

Thanks!