IonMonkey: MIPS: Add add64 to mips32

RESOLVED FIXED in Firefox 45

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hev, Assigned: hev)

Tracking

unspecified
mozilla45
Other
Linux
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Implement add64(Register, Register) to mips32.
(Assignee)

Comment 1

3 years ago
Created attachment 8695642 [details] [diff] [review]
0001-IonMonkey-MIPS-Add-add64-to-mips32.patch
Attachment #8695642 - Flags: review?(arai.unmht)
Comment on attachment 8695642 [details] [diff] [review]
0001-IonMonkey-MIPS-Add-add64-to-mips32.patch

Review of attachment 8695642 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/MacroAssembler-mips32-inl.h
@@ +83,5 @@
> +{
> +    as_addu(ScratchRegister, dest.low, src.low);
> +    as_sltu(dest.low, ScratchRegister, dest.low);
> +    as_addu(dest.high, dest.high, src.high);
> +    as_addu(dest.high, dest.low, dest.high);

The value of dest.low is incorrect.
ScratchRegister contains |dest.low + src.low| value after those operations.
Attachment #8695642 - Flags: review?(arai.unmht) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8695703 [details] [diff] [review]
0001-IonMonkey-MIPS-Add-add64-to-mips32.patch

Thank you!
Attachment #8695642 - Attachment is obsolete: true
Attachment #8695703 - Flags: review?(arai.unmht)
Comment on attachment 8695703 [details] [diff] [review]
0001-IonMonkey-MIPS-Add-add64-to-mips32.patch

Review of attachment 8695703 [details] [diff] [review]:
-----------------------------------------------------------------

nice fix :)
Attachment #8695703 - Flags: review?(arai.unmht) → review+

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c5bb0d79271
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.