Closed Bug 1230409 Opened 4 years ago Closed 4 years ago

Add offsetInsOffsetBy to non-ion

Categories

(Core :: JavaScript Engine: JIT, defect)

44 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: stevensn, Assigned: bbouvier)

References

Details

Attachments

(1 file)

Building on a non-ion platform gives


js/src/jit/shared/Assembler-shared.h:788:30: error: \u2018class js::wasm::HeapAccess\u2019 has no member named \u2018offsetInsnOffsetBy\u2019
108:59.44              heapAccesses_[i].offsetInsnOffsetBy(delta);
Attached patch nonion.patchSplinter Review
Assignee: steve → benj
Status: NEW → ASSIGNED
Attachment #8695829 - Flags: review?(luke)
Comment on attachment 8695829 [details] [diff] [review]
nonion.patch

Review of attachment 8695829 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, I had really meant to check this but then forgot.
Attachment #8695829 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/4f5638bac44c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.