1230413 - More gfxContext-to-DrawTarget conversion clean-ups

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

Some more clean-ups.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Pass a DrawTarget to several PaintFocus functions()

Instead of an nsRenderingContext.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Change CallbackData::mContext to a DrawTarget

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove unused gfxContext argument from SetSpaceGlyphIfSimple()

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove unused gfxContext argument from SetSpaceGlyphIfSimple()

(Fixed log message.)

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Remove unused nsRenderingContext argument from ForceBreak() and OptionallyBreak()

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Pass a DrawTarget to Draw{Dashed,SolidBorder}Segment()

Instead of an nsRenderingContext.

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 8695658 [details] [diff] [review]
(part 2) - Change CallbackData::mContext to a DrawTarget

Review of attachment 8695658 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxGraphiteShaper.h
@@ +45,5 @@
>  
>      struct CallbackData {
> +        gfxFont* mFont;
> +        gfxGraphiteShaper* mShaper;
> +        mozilla::gfx::DrawTarget* mDrawTarget;

For bonus points, you can remove the mShaper field from this struct while you're in the area; AFAICS it's set by the gfxGraphiteShaper constructor, but then never actually used.

Comment 8

[Jonathan Kew [:jfkthame]]

Comment on attachment 8695663 [details] [diff] [review]
(part 3) - Remove unused gfxContext argument from SetSpaceGlyphIfSimple()

Review of attachment 8695663 [details] [diff] [review]:
-----------------------------------------------------------------

Duh!

Comment 9

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b73d6323bf42587b42fcf7f2de928397940c2053
Bug 1230413 (part 1) - Pass a DrawTarget to several PaintFocus functions(). r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a47d95507944043c839f2ee6bfedf7c515afbe5f
Bug 1230413 (part 2) - Change CallbackData::mContext to a DrawTarget. r=jfkthame.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7f8a69c7bf3f3ff2ff61cf24a4eba3585e2669c
Bug 1230413 (part 3) - Remove unused gfxContext argument from SetSpaceGlyphIfSimple(). r=jfkthame.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1cf548298482c22ce9b51002a84e998bcff61a4
Bug 1230413 (part 4) - Remove unused nsRenderingContext argument from ForceBreak() and OptionallyBreak(). r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/503dbfc06901e4117b4054194dfc82b778fc56b4
Bug 1230413 (part 5) - Pass a DrawTarget to Draw{Dashed,SolidBorder}Segment(). r=mattwoodrow.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b73d6323bf42
https://hg.mozilla.org/mozilla-central/rev/a47d95507944
https://hg.mozilla.org/mozilla-central/rev/e7f8a69c7bf3
https://hg.mozilla.org/mozilla-central/rev/e1cf54829848
https://hg.mozilla.org/mozilla-central/rev/503dbfc06901