Remove -webkit-border-image longhand property aliases

RESOLVED FIXED in Firefox 45

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: miketaylr, Assigned: miketaylr)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

While working on speccing -webkit-border-image @ <https://github.com/whatwg/compat/issues/17>, I noticed that my longhand props test case wasn't rendering in Edge.

I reached out to Jacob Rossi who referred me to Matt Rakow and he wrote that they were implemented in Edge, but they removed them earlier this year.

My bad for not doing my homework when I suggested we follow Edge in https://bugzilla.mozilla.org/show_bug.cgi?id=1179393#c3. /o\

Daniel, not sure if it's "better" to revert your patch in Bug 1179393, or write a new one. But I have one ready in case you think the latter is OK.
Created attachment 8695694 [details] [diff] [review]
1230426.-Remove-support-for-webkit-border-image-longhand.patch

(I guess the silver lining is this never made it out of Nightly/45.)
Attachment #8695694 - Flags: review?(dholbert)
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e153ab847b51
Note to self: the commit message would be better as "Remove support for -webkit-border-image longhand CSS property aliases.", I think.
Comment on attachment 8695694 [details] [diff] [review]
1230426.-Remove-support-for-webkit-border-image-longhand.patch

Review of attachment 8695694 [details] [diff] [review]:
-----------------------------------------------------------------

Do you know why Edge removed them? (Do these prefixed longhands just not have enough usage to matter?)

r=me regardless. Thanks for catching this!
Attachment #8695694 - Flags: review?(dholbert) → review+
(comment 3's commit message -- just adding "aliases" -- sounds good.)
Blocks: 1179393
See Also: bug 1179393
Thanks for review!

(In reply to Daniel Holbert [:dholbert] from comment #4)
> Do you know why Edge removed them? (Do these prefixed longhands just not
> have enough usage to matter?)

So it's kind of embarrassing, but it turns out WebKit (and thus Blink) never shipped prefixed longhand properties. I found this out reading some super old blog posts but wanted to confirm with the Edge team in case they had some extra information. It seems like we did the same thing as MS, "Turned out we were a little overzealous in our aliasing efforts."

(I guess a funny story we can tell one day, how two non-WebKit browser supported longhand -webkit-border-image props for a brief period of time in non-release builds.)
Created attachment 8695920 [details] [diff] [review]
1230426.-Remove-support-for-webkit-border-image-.patch

Updating commit message and carrying forward r+.
Attachment #8695694 - Attachment is obsolete: true
Attachment #8695920 - Flags: review+
All the oranges in the try run appear to be unrelated intermittents, so setting checkin-needed.
Keywords: checkin-needed

Comment 9

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1208659f1a97
Keywords: checkin-needed

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1208659f1a97
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.