Closed Bug 1230438 Opened 4 years ago Closed 4 years ago

Remove code for tracking Tiles

Categories

(Firefox for Android :: Awesomescreen, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
fennec 46+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Bug 1068425 added a decent amount of code to send metrics to Mozilla about Tile clicks. I think we can remove this code. Four changesets landed in that bug. One of those [1] looks like it was a pure refactor patch, and we can probably leave it alone.

Bug 1126514 added code for giving IDs for built-in tiles. We can probably leave that as-is.

[1] https://hg.mozilla.org/mozilla-central/rev/01a4dd4275fe
tracking-fennec: --- → ?
Assignee: nobody → mark.finkle
Brian - I'm hoping you can help with a sanity check on this patch. I looked at the initial bug and the followup bugs to get an idea of what code to remove:

bug 1068425 - Track tile metrics
bug 1071039 - Add ID to suggested sites (removed all)
bug 1076438 - Distribution thumbnails missing for pinned sites (removed the tracking ID patch)
bug 1095514 - Intermittent testDistribution (the test code was removed anyway, but left the BaseTest addition)
bug 1105011 - Include locale in tiles upload (removed most of it, but left some unrelated code in BaseTest)
bug 1126514 - Add Fennec tile IDs for built in tiles (will remove in bug 1216987)

This seems to build fine and passes tests:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=65f9b27f05b1
Attachment #8699524 - Flags: review?(bnicholson)
tracking-fennec: ? → 46+
Comment on attachment 8699524 [details] [diff] [review]
remove-tiletracking v0.1

Review of attachment 8699524 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me if it works!
Attachment #8699524 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/f696bbc40e10
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8699524 [details] [diff] [review]
remove-tiletracking v0.1

Approval Request Comment
[Feature/regressing bug #]: Content Services has never, and will never, track tiles from Mobile
[User impact if declined]: Less code and less network requests.
[Describe test coverage new/current, TreeHerder]: Working on Nightly
[Risks and why]: Should be low. Removing code which was not needed for app usage. Should uplift to aurora without merge issues.
[String/UUID change made/needed]: None
Attachment #8699524 - Flags: approval-mozilla-aurora?
Comment on attachment 8699524 [details] [diff] [review]
remove-tiletracking v0.1

Less code is good, taking it.
Attachment #8699524 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.