Add a UDEV file to B2G for easy environment set up

RESOLVED WONTFIX

Status

Firefox OS
GonkIntegration
RESOLVED WONTFIX
2 years ago
10 months ago

People

(Reporter: adfad666, Assigned: adfad666)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

43 bytes, text/x-github-pull-request
gerard
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
Our build instructions tell us to edit this file (51-android.rules), but don't tell us where to get it from! Google's list limits usage to one user. CyanogenMod's list is embedded in a Wiki. If we have our own file we can set up everything in a single command for all users.
(Assignee)

Comment 1

2 years ago
Created attachment 8695773 [details] [review]
B2G PR

Based on http://developer.android.com/tools/device.html#VendorIds plus some extra used by CM devices
Attachment #8695773 - Flags: review?(lissyx+mozillians)
Assignee: nobody → afarden
Comment on attachment 8695773 [details] [review]
B2G PR

Good to me but I would prefer the doc at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Building_and_installing_Firefox_OS/Establish_a_Build_Environment#Configure_USB_access to refer to the local checkout of the user and avoid feeding bad habits of the "wget | sudo" scheme :)
Attachment #8695773 - Flags: review?(mwu)
Attachment #8695773 - Flags: review?(lissyx+mozillians)
Attachment #8695773 - Flags: review+

Comment 3

2 years ago
The contents look ok to me, but I usually avoid prefixing the udev file with a number to force the rule to run last. Often times, the user's distro will have rules which run afterwards which can undo the adb rules. Instructions that I write explicitly leave out the number, but people end up thinking it's an omission and put it back..
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → WONTFIX
Attachment #8695773 - Flags: review?(mwu.code)
You need to log in before you can comment on or make changes to this bug.