Status

()

Firefox for Android
Graphics, Panning and Zooming
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kats, Assigned: jmaher)

Tracking

unspecified
Firefox 45
All
Android
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

The tcheck2 test worked for the old JPZC because it used specific APIs to record checkerboarding that worked with JPZC. With the C++ APZ we have async subframe scrolling so the notion of checkerboarding is more complicated. We have plans to get detailed checkerboarding metrics in bug 1226826, and once we have that we should rewrite the tcheck2 test to use it.

Fundamentally I think the tcheck2 test should be written the same way it was before (i.e. load a page in Fennec, simulate a bunch of user actions, measure checkerboarding), but perhaps expand it to cover different kinds of sites.
(Assignee)

Comment 1

2 years ago
Created attachment 8695918 [details] [diff] [review]
buildbot configs to turn off robocheck2 on all branches

here are the builders removed:
Builders removed
- Android 4.0 armv7 API 11+ alder talos remote-trobocheck2
- Android 4.0 armv7 API 11+ ash talos remote-trobocheck2
- Android 4.0 armv7 API 11+ b2g-inbound talos remote-trobocheck2
- Android 4.0 armv7 API 11+ cedar talos remote-trobocheck2
- Android 4.0 armv7 API 11+ fx-team talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-aurora talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-beta talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-central talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-inbound talos remote-trobocheck2
- Android 4.0 armv7 API 11+ try talos remote-trobocheck2
Attachment #8695918 - Flags: review?(bugspam.Callek)
Comment on attachment 8695918 [details] [diff] [review]
buildbot configs to turn off robocheck2 on all branches

Review of attachment 8695918 [details] [diff] [review]:
-----------------------------------------------------------------

So after chatting on IRC with joel, we expect trobo2 to die completely, thus removing the config cruft will be a benefit.

Places I noticed
https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla-tests/mobile_config.py#158

https://dxr.mozilla.org/build-central/source/tools/trychooser/index.html#537

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/android/android_panda_talos_releng.py#53
https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos.json#111
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/android_panda_talos.py#68
Attachment #8695918 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 3

2 years ago
Created attachment 8695923 [details] [diff] [review]
buildbot configs to disable rck2 and other unused tests (2.0)
Attachment #8695918 - Attachment is obsolete: true
Attachment #8695923 - Flags: review?(bugspam.Callek)
Attachment #8695923 - Flags: review?(bugspam.Callek) → review+

Comment 4

2 years ago
How about we call it tcheck3 ?
(Assignee)

Comment 5

2 years ago
Created attachment 8695937 [details] [diff] [review]
mozilla-central - remove rck2 references (1.0)

this cleans up the talos.json and mozharness configs, pushed to try for sanity:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a72e080ac48a
Attachment #8695937 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 6

2 years ago
landed the buildbot-config change:
https://hg.mozilla.org/build/buildbot-configs/rev/1f285543a146
Comment on attachment 8695937 [details] [diff] [review]
mozilla-central - remove rck2 references (1.0)

Review of attachment 8695937 [details] [diff] [review]:
-----------------------------------------------------------------

surprised we can kill this much kruft, but YAY that we can.
Attachment #8695937 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 8

2 years ago
Created attachment 8695939 [details] [diff] [review]
clean up trychooser as well
Attachment #8695939 - Flags: review?(bugspam.Callek)
(Assignee)

Updated

2 years ago
Attachment #8695923 - Flags: checkin+
Attachment #8695939 - Flags: review?(bugspam.Callek) → review+
Assignee: nobody → jmaher
No longer depends on: 1226826
Summary: Rewrite Fennec checkerboarding tests for APZ → Remove tcheck2
I filed bug 1230598 for writing new tests since this one is being used for removing the old test.
(Assignee)

Comment 10

2 years ago
try chooser is landed:
https://hg.mozilla.org/build/tools/rev/fbe3196587fc

regarding the m-c bits, we need the buildbot-reconfig to take place first- we are scheduling rck2 still but there is no definition in mozharness/talos.json.

Comment 11

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/faacb2337f8e

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/faacb2337f8e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.