Closed Bug 1230572 Opened 4 years ago Closed 4 years ago

Remove tcheck2

Categories

(Firefox for Android :: Toolbar, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: kats, Assigned: jmaher)

Details

Attachments

(3 files, 1 obsolete file)

The tcheck2 test worked for the old JPZC because it used specific APIs to record checkerboarding that worked with JPZC. With the C++ APZ we have async subframe scrolling so the notion of checkerboarding is more complicated. We have plans to get detailed checkerboarding metrics in bug 1226826, and once we have that we should rewrite the tcheck2 test to use it.

Fundamentally I think the tcheck2 test should be written the same way it was before (i.e. load a page in Fennec, simulate a bunch of user actions, measure checkerboarding), but perhaps expand it to cover different kinds of sites.
here are the builders removed:
Builders removed
- Android 4.0 armv7 API 11+ alder talos remote-trobocheck2
- Android 4.0 armv7 API 11+ ash talos remote-trobocheck2
- Android 4.0 armv7 API 11+ b2g-inbound talos remote-trobocheck2
- Android 4.0 armv7 API 11+ cedar talos remote-trobocheck2
- Android 4.0 armv7 API 11+ fx-team talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-aurora talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-beta talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-central talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-inbound talos remote-trobocheck2
- Android 4.0 armv7 API 11+ try talos remote-trobocheck2
Attachment #8695918 - Flags: review?(bugspam.Callek)
Attachment #8695918 - Attachment is obsolete: true
Attachment #8695923 - Flags: review?(bugspam.Callek)
Attachment #8695923 - Flags: review?(bugspam.Callek) → review+
How about we call it tcheck3 ?
this cleans up the talos.json and mozharness configs, pushed to try for sanity:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a72e080ac48a
Attachment #8695937 - Flags: review?(bugspam.Callek)
Comment on attachment 8695937 [details] [diff] [review]
mozilla-central - remove rck2 references (1.0)

Review of attachment 8695937 [details] [diff] [review]:
-----------------------------------------------------------------

surprised we can kill this much kruft, but YAY that we can.
Attachment #8695937 - Flags: review?(bugspam.Callek) → review+
Attachment #8695939 - Flags: review?(bugspam.Callek)
Attachment #8695923 - Flags: checkin+
Attachment #8695939 - Flags: review?(bugspam.Callek) → review+
Assignee: nobody → jmaher
No longer depends on: 1226826
Summary: Rewrite Fennec checkerboarding tests for APZ → Remove tcheck2
I filed bug 1230598 for writing new tests since this one is being used for removing the old test.
try chooser is landed:
https://hg.mozilla.org/build/tools/rev/fbe3196587fc

regarding the m-c bits, we need the buildbot-reconfig to take place first- we are scheduling rck2 still but there is no definition in mozharness/talos.json.
https://hg.mozilla.org/mozilla-central/rev/faacb2337f8e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.